Skip to content

fix: handled thread not found result on frontend - #374

Merged
arbrandes merged 1 commit into
openedx:open-release/olive.masterfrom
arbrandes:backport-thread-not-found-fix
Dec 8, 2022
Merged

fix: handled thread not found result on frontend#374
arbrandes merged 1 commit into
openedx:open-release/olive.masterfrom
arbrandes:backport-thread-not-found-fix

Conversation

@arbrandes

Copy link
Copy Markdown
Contributor

This is the backport of a fix with an accompanying backend change (included in the backports PR).

@codecov

codecov Bot commented Dec 7, 2022

Copy link
Copy Markdown

Codecov Report

Base: 85.19% // Head: 85.08% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (087ed3b) compared to base (5c3d561).
Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           open-release/olive.master     #374      +/-   ##
=============================================================
- Coverage                      85.19%   85.08%   -0.12%     
=============================================================
  Files                            134      134              
  Lines                           2675     2682       +7     
  Branches                         737      741       +4     
=============================================================
+ Hits                            2279     2282       +3     
- Misses                           374      378       +4     
  Partials                          22       22              
Impacted Files Coverage Δ
src/discussions/comments/messages.js 100.00% <ø> (ø)
src/discussions/posts/post-editor/messages.js 100.00% <ø> (ø)
src/discussions/posts/post-editor/PostEditor.jsx 85.14% <20.00%> (-2.61%) ⬇️
src/discussions/comments/CommentsView.jsx 95.00% <100.00%> (+0.26%) ⬆️
src/discussions/comments/comment/Comment.jsx 95.55% <100.00%> (+0.10%) ⬆️
src/discussions/posts/data/api.js 91.89% <100.00%> (ø)
src/discussions/posts/data/thunks.js 87.06% <100.00%> (-0.87%) ⬇️
src/discussions/posts/data/slices.js 79.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes
arbrandes requested a review from xitij2000 December 7, 2022 11:15
@arbrandes

Copy link
Copy Markdown
Contributor Author

@xitij2000, mind giving this a thumbs up? And while you're at it, a corresponding one to the edx-platform bits?

@mehaknasir
mehaknasir self-requested a review December 8, 2022 08:59
@arbrandes

Copy link
Copy Markdown
Contributor Author

Approved by @asadazam93 in Slack.

@arbrandes
arbrandes merged commit e89792b into openedx:open-release/olive.master Dec 8, 2022
@arbrandes
arbrandes deleted the backport-thread-not-found-fix branch December 8, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants