Skip to content

feat: Add support for the Discussions MFE - #91

Merged
arbrandes merged 1 commit into
overhangio:nightlyfrom
arbrandes:add-discussions
Dec 9, 2022
Merged

feat: Add support for the Discussions MFE#91
arbrandes merged 1 commit into
overhangio:nightlyfrom
arbrandes:add-discussions

Conversation

@arbrandes

@arbrandes arbrandes commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Adds support for the Discussions MFE, enabling it by default.

Optional features also enabled via waffle flag:

  • Learner's tab in the MFE
  • Extended moderation reason codes
  • Reported content email notifications to moderators
  • Enable learner stats in the activity API

Requirements

@arbrandes arbrandes mentioned this pull request Nov 28, 2022
Closed
3 tasks
@arbrandes
arbrandes marked this pull request as ready for review November 28, 2022 20:54
@arbrandes
arbrandes requested a review from regisb November 28, 2022 20:54
@arbrandes

arbrandes commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator Author

@regisb, I'm still waiting on the backports from master to Olive in cs_comments_service and edx-platform, but the tutor-mfe bits are good enough to review, and the MFE actually works... as far as I can tell. I still see fixes to frontend-app-discussions coming in (I had to whip one up myself), so we'll want to keep our eyes open to pick them up before release day.

regisb
regisb reviewed Nov 29, 2022
View reviewed changes
Comment thread README.rst
regisb
regisb approved these changes Nov 29, 2022
View reviewed changes

@regisb regisb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But we agree that we are not going to merge this PR in master, right? (only in Olive or nightly)

@arbrandes
arbrandes force-pushed the add-discussions branch 2 times, most recently from e57d85f to 0b113a2 Compare November 29, 2022 12:42
@arbrandes
arbrandes changed the base branch from master to nightly November 29, 2022 12:44
@arbrandes

arbrandes commented Nov 29, 2022

Copy link
Copy Markdown
Collaborator Author

@regisb, yes, definitely nightly!

@arbrandes

arbrandes commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator Author

Ok, I've tested this in nightly and olive, and it's looking good AFAICT. We're just blocked on the edx-platform fixes.

@arbrandes

arbrandes commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator Author

Rebased on the new runtime config support: good enough for nightly. Probably worth another glance, @regisb.

@arbrandes arbrandes mentioned this pull request Dec 7, 2022
Merged
regisb
regisb approved these changes Dec 8, 2022
View reviewed changes

@regisb regisb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Adolfo R. Brandes @arbrandes
feat: Add support for the Discussions MFE
4455c09 
Adds support for the Discussions MFE, enabling it by default.

Optional features also enabled via waffle flag:

* Learner's tab in the MFE
* Extended moderation reason codes
* Reported content email notifications to moderators
* Enable learner stats in the activity API
@arbrandes

arbrandes commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator Author

...aaand, we're in!

@arbrandes
arbrandes merged commit 5e2da85 into overhangio:nightly Dec 9, 2022
@arbrandes
arbrandes deleted the add-discussions branch December 9, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regisb regisb regisb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arbrandes @regisb