Skip to content

fix: delay creation of course topics after course publish [BD-38] - #31307

Merged
asadazam93 merged 1 commit into
openedx:masterfrom
open-craft:kshitij/fix-discussion-topic-creation-delay
Nov 18, 2022
Merged

fix: delay creation of course topics after course publish [BD-38]#31307
asadazam93 merged 1 commit into
openedx:masterfrom
open-craft:kshitij/fix-discussion-topic-creation-delay

Conversation

@xitij2000

Copy link
Copy Markdown
Contributor

Description

When running in a sharded MongoDB setup it's possible that querying the
modulestore right after the course publish signal will not return the
latest data.

This commit adds a delay similar to the one used in other places in the
codebase for a similar reason.

Testing instructions

This needs to be tested in a production-like environment where the delay between
a write to Mongo and it's propagation to a read-replica is significant enough
to have an impact.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 18, 2022
@openedx-webhooks

openedx-webhooks commented Nov 18, 2022

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

When this pull request is ready, tag your edX technical lead.

@xitij2000 xitij2000 changed the title fix: delay creation of course topics after course publish fix: delay creation of course topics after course publish [BD-38] Nov 18, 2022
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Nov 18, 2022
@asadazam93

Copy link
Copy Markdown
Contributor

@xitij2000 can you please rebase? Seems to be out of date

When running in a sharded MongoDB setup it's possible that querying the
modulestore right after the course publish signal will not return the
latest data.

This commit adds a delay similar to the one used in other places in the
codebase for a similar reason.
@xitij2000
xitij2000 force-pushed the kshitij/fix-discussion-topic-creation-delay branch from 53cf114 to 123624d Compare November 18, 2022 09:54
@asadazam93
asadazam93 merged commit de0b132 into openedx:master Nov 18, 2022
@openedx-webhooks

Copy link
Copy Markdown

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@xitij2000
xitij2000 deleted the kshitij/fix-discussion-topic-creation-delay branch November 24, 2022 07:35
arbrandes pushed a commit that referenced this pull request Dec 8, 2022
When running in a sharded MongoDB setup it's possible that querying the
modulestore right after the course publish signal will not return the
latest data.

This commit adds a delay similar to the one used in other places in the
codebase for a similar reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants