Skip to content

Clean up Mongo databases created by the test suite. - #2467

Merged
wedaly merged 1 commit into
masterfrom
will/clean-test-mongo-dbs
Feb 5, 2014
Merged

Clean up Mongo databases created by the test suite.#2467
wedaly merged 1 commit into
masterfrom
will/clean-test-mongo-dbs

Conversation

@wedaly

@wedaly wedaly commented Feb 4, 2014

Copy link
Copy Markdown
Contributor

Deletes Mongo databases that were being created by the unit and acceptance test suites.
@davestgermain @jzoldak

https://edx-wiki.atlassian.net/browse/TE-339

@jzoldak

jzoldak commented Feb 4, 2014

Copy link
Copy Markdown
Contributor

@dglance there are so many changes being made to the rake files for testing, that we feel it shouldn't be on you to keep up with them before getting your stuff merged in. @wedaly and I were discussing and maybe the best way to tackle it is for you to not worry about test tasks. If you leave the rake test tasks not deprecated on #2146 we will take on the responsibility for translating them to paver. That makes sense anyhow because then we can make sure our jenkins server does the appropriate thing.

@jzoldak

jzoldak commented Feb 5, 2014

Copy link
Copy Markdown
Contributor

@wedaly
Testing on devstack, I confirmed that both these worked, both with and without dbs named test_foo:

rake test:clean_mongo
mongo delete-mongo-test-dbs.js

But then when I ran rake test and checked afterwards, there are 3 test_xcontent_foo dbs remaining. :(

@wedaly

wedaly commented Feb 5, 2014

Copy link
Copy Markdown
Contributor Author

@jzoldak I forgot that Rake ignores repeated invocations of a task unless you re-enable it. Should be fixed now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good place to put a more general cleanup task that would do clean_mongo in addition to anything else in the future, rather than repeating this in a few places.
but if rake is going away anyway, probably not worth it.

@davestgermain

Copy link
Copy Markdown
Contributor

👍

@jzoldak

jzoldak commented Feb 5, 2014

Copy link
Copy Markdown
Contributor

👍

wedaly pushed a commit that referenced this pull request Feb 5, 2014
Clean up Mongo databases created by the test suite.
@wedaly
wedaly merged commit a2502d6 into master Feb 5, 2014
@wedaly
wedaly deleted the will/clean-test-mongo-dbs branch February 5, 2014 19:08
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Mar 23, 2018
* Add ORA2 video upload option openedx#2375 (openedx#2417)

* Modified courseware page look and feel openedx#2377 (openedx#2409)

* Modified about page openedx#2379 (openedx#2413)

* Fix biz bugs. openedx#2404 (openedx#2406)

* Fix display width of popup. (openedx#2384)

(cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95)

* Validate duplicate url-code.

* Fix bug, when course not found.

* Fix order of course as CourseOverview.

* Remove additional-info count from contract grid. openedx#2419 (openedx#2437)

* Fix order global course. openedx#2420 (openedx#2421)

* Add additional info register. openedx#2419 (openedx#2433)

* fix survey csv character encode problem openedx#2380 (openedx#2434)

* Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457)

* Fix register students confirm message. (openedx#2461)

* Add command to check playback_log. openedx#2438 (openedx#2445)

* Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453)

* Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467)

* Fix bugs. openedx#2462 openedx#2463 (openedx#2464)

* Fix password message in register students page.

* Fix glass pane of processing when register additional item.

* Fix display width of popup. (openedx#2466)

* Fix min-width of sequence-nav. openedx#2468 (openedx#2469)

* Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants