Reduce the usage of <section> tags, to increase accessibility - #2439
Merged
Conversation
Contributor
Author
Contributor
|
This looks good. I wonder about making some of the selectors less specific, but this is mergeable. 👍 |
Contributor
Contributor
|
On second thought, after diving into the Sass a bit, I'd prefer to clean up selectors as a separate piece of work - there's enough very rough rules and thus changes needed that some manual testing of UI rendering will be needed. I don't want that to slow this work around a bug down. Once you rebase and tests pass, 👍 I'll add a separate less urgent bug about the selectors to not drop that ball. |
…ach section, they should not be used unless they are actually defining meaningful sections.
davestgermain
pushed a commit
that referenced
this pull request
Feb 5, 2014
Reduce the usage of <section> tags, to increase accessibility LMS-2161
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 23, 2018
* Add ORA2 video upload option openedx#2375 (openedx#2417) * Modified courseware page look and feel openedx#2377 (openedx#2409) * Modified about page openedx#2379 (openedx#2413) * Fix biz bugs. openedx#2404 (openedx#2406) * Fix display width of popup. (openedx#2384) (cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95) * Validate duplicate url-code. * Fix bug, when course not found. * Fix order of course as CourseOverview. * Remove additional-info count from contract grid. openedx#2419 (openedx#2437) * Fix order global course. openedx#2420 (openedx#2421) * Add additional info register. openedx#2419 (openedx#2433) * fix survey csv character encode problem openedx#2380 (openedx#2434) * Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457) * Fix register students confirm message. (openedx#2461) * Add command to check playback_log. openedx#2438 (openedx#2445) * Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453) * Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467) * Fix bugs. openedx#2462 openedx#2463 (openedx#2464) * Fix password message in register students page. * Fix glass pane of processing when register additional item. * Fix display width of popup. (openedx#2466) * Fix min-width of sequence-nav. openedx#2468 (openedx#2469) * Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because screen readers announce each section on the page,
<section>tags should only be used where there is a semantic section on the page. There are currently many inappropriate uses of the tag. This PR reduces them.@talbs