preview_handler changes to support Locators - #2434
Conversation
|
👍 after rebasing and ensuring tests pass |
|
@dmitchell and @cpennington PR is rebased, tests passing. |
There was a problem hiding this comment.
Are you sure getting rid of data_dir is the right thing to do?
There was a problem hiding this comment.
None is passed for data_directory in the call above. I looked at the code that is being called, and it seems that data_directory is only used for XML modulestore (which Studio doesn't use). The code is in /edx-platform/common/djangoapps/static_replace/init.py
I couldn't think of any reason why the arguments should be different in the 2 places. Do you know of a reason why they should differ?
There was a problem hiding this comment.
Fair enough. I think that should be fine in this code. Another good reason that we should clean up the api for the ContentStore and static replacement, so that we don't have to have all of these special cases depending on whether we're in an XML world or a mongo one.
|
👍 once my comments are addressed. |
preview_handler changes to support Locators
* Add ORA2 video upload option openedx#2375 (openedx#2417) * Modified courseware page look and feel openedx#2377 (openedx#2409) * Modified about page openedx#2379 (openedx#2413) * Fix biz bugs. openedx#2404 (openedx#2406) * Fix display width of popup. (openedx#2384) (cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95) * Validate duplicate url-code. * Fix bug, when course not found. * Fix order of course as CourseOverview. * Remove additional-info count from contract grid. openedx#2419 (openedx#2437) * Fix order global course. openedx#2420 (openedx#2421) * Add additional info register. openedx#2419 (openedx#2433) * fix survey csv character encode problem openedx#2380 (openedx#2434) * Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457) * Fix register students confirm message. (openedx#2461) * Add command to check playback_log. openedx#2438 (openedx#2445) * Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453) * Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467) * Fix bugs. openedx#2462 openedx#2463 (openedx#2464) * Fix password message in register students page. * Fix glass pane of processing when register additional item. * Fix display width of popup. (openedx#2466) * Fix min-width of sequence-nav. openedx#2468 (openedx#2469) * Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
3 participants
@cpennington and @dmitchell Please review.
This is STUD-967, changing the code so that it will be able to handle descriptor.location being a Locator instead of a Location.
The changes ended up being minimal-- it was mostly just thinking through whether or not the usages of descriptor.location will be OK for Locators. I added some comments in the code for particular usages that were not obvious (to me).
@cpennington I am including you because you wrote the partial(replace_static_urls... code that I'm changing. I don't see why the arguments for that should be different from the arguments to replace_static_urls right above. data_dir is not needed for courses not being served out of xml_modulestore, and we already have a course_id defined.