LMS: Adds Language Selection Menu - #2419
Conversation
|
This work also relates to https://github.com/edx/edx-platform/pull/2418 |
There was a problem hiding this comment.
Shouldn’t there be only the list of languages that are properly (above X%?) translated on transifex?
There was a problem hiding this comment.
@tusbar, yes. This is my first pass (as a Designer) plumbing through the UI. These values where just to help other team members understand the format we're using and for me to gauge the UI under large list conditions. This will be fully automated and integrated with the platform. :)
Apologies for the confusion.
There was a problem hiding this comment.
This list will actually be generated on the server, from the list of actually-supported languages. Our plan is that it will present like this though, with each language presented in its own language.
|
@marcotuts, mind reviewing this from a design/FED perspective? |
|
Can English at least show up in this menu? Also, maybe here would be a good place to plug Transifex. "Don't see your preferred language? Volunteer to become a translator!" with the second sentence linking to https://github.com/edx/edx-platform/blob/master/docs/en_us/developers/source/i18n_translators_guide.rst |
|
Visiting http://127.0.0.1:8000/dashboard?preview-lang=en@lolcat doesn't break on master but it does on this branch. |
There was a problem hiding this comment.
is there a way to just define this once in this file in case things change (eg we change how the dummy language is defined)
|
Can you set a few languages that can show up in the dropdown menu in a development environment ("fr", "eo", "ko-kr", "es-419" please)? |
|
@sarina thanks for the UI suggestion about getting the word out with helping with translating the platform. Sounds reasonable to me - @shnayder, what do you think of this from a product perspective? |
|
@talbs I like the idea of adding a pointer to the translation volunteer instructions. I also like the idea of adding English to the list... |
|
@shnayder, thanks! I'll take care of adding the link in. My assumption is that the work that @dianakhuang is doing or @flowerhack has done will populate that select element with the languages the platform supports, including English. Gang, is that assumption correct? |
|
@talbs Yes, I'm building out some better default behavior when you don't have any languages 'released' such that English shows up if you don't have anything configured. @sarina I don't think it makes sense to populate that list in a special way just for development environments. Since that configuration lives in the database, it's not as simple as messing with the |
There was a problem hiding this comment.
Looks like we lost this line, which I added recently.
|
@sarina, mentioned this in a now outdated diff, but I added translator help text to the modal cases you brought up. I also tried to find any other modals that were in the same situation and sync them up with same help copy. |
There was a problem hiding this comment.
Why is this change in this pull request?
There was a problem hiding this comment.
It looks like @wedaly added it to this story to handle dark language things:
|
@talbs awesome - I know I had no idea what a modal was until just a few months ago. @dianakhuang ah it was just wishful thinking that dev environments could be set up to test this feature differently. Thanks for the testing notes, I'll poke around some more. |
|
@dianakhuang, I'm running into a local env devstack issue which looks to be happening due to a server error on the branch - re-provisioning my vagrant machine kicks me back to the master branch as part of its process. When I switch back to this branch and pop my stash of changes, I still receive the server error. My one outstanding task is to add the link to the translation docs (per @sarina's suggestion). Let me know when it may be safer to try to work locally on this task. |
|
Not sure how much we care about this bug but:
When the modal closes, you're still at the url http://127.0.0.1:8000/dashboard?preview-lang=eo so the language still is Esperanto. Removing the ?preview-lang=eo from the URL, then following the steps, works properly. |
|
I think it makes sense to force "English" to always be in the list of released languages, as I think this is too easy to mess up. When I do I see |
|
YIKES also when I do that and select Korean this is what I see in my dashboard afterwards!!! Note I tried this a few languages: Note: this is my darklang config now: |
|
is this a bug:
|
|
@talbs visually it looks odd that there's an icon to the left of email and name but not language: |
|
I'm currently unable to load the LMS through devstack on this branch, though going back to master or other branches works fine. Rake devstack[lms] works, but when I attempt to load the LMS, I see that middleware.py isn't recognized. rake resetdb[devstack] didn't seem to fix this. If anybody has suggestions for how to resolve this let me know! thanks! |
|
I left a pile of nitpicky comments about test cases. Overall the code and functionality is well done. 👍 once my concerns addressed. |
|
Okay, I think i nipped the last of @sarina 's comments in the bud, and bok-choy should be passing now... (I am getting failures on XBlockAcidTest locally, though? Maybe this needs another rebase @dianakhuang ?) |
|
so there are still a good number of pylints https://jenkins.testeng.edx.org/job/edx-platform-report-manual/300/Diff_Quality_Report/? Can you let me know if these are things that you can fix or should be skipped? If you can fix them please do. If they ought to be skipped and are being erroneously reported I will try to fix in a separate PR. Thanks. |
|
Once pylint addressed 🚢 |
👍 ✨ 🚀
|
The thing about the pylint violations is that they were all existing violations that were in |
|
Ugh. @gwprice can you put it on your backlog to document that code and fix the violations? It's scary when we have production code that is poorly understood to the point that other developers don't feel like they are capable of adding docstrings. thanks @dianakhuang . bring this baby to mergetown once commits are nicely squashed |
Will pass once the language persistence stuff gets merged in
Also, refactor tests such that we're not deleting users or prefs
instead of the current language.
* Don't show sidebar if only one language is present * only add in the default language code if it's not already present
Fixed bok-choy acceptance tests
|
👍 |
LMS: Adds Language Selection Menu
* Add ORA2 video upload option openedx#2375 (openedx#2417) * Modified courseware page look and feel openedx#2377 (openedx#2409) * Modified about page openedx#2379 (openedx#2413) * Fix biz bugs. openedx#2404 (openedx#2406) * Fix display width of popup. (openedx#2384) (cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95) * Validate duplicate url-code. * Fix bug, when course not found. * Fix order of course as CourseOverview. * Remove additional-info count from contract grid. openedx#2419 (openedx#2437) * Fix order global course. openedx#2420 (openedx#2421) * Add additional info register. openedx#2419 (openedx#2433) * fix survey csv character encode problem openedx#2380 (openedx#2434) * Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457) * Fix register students confirm message. (openedx#2461) * Add command to check playback_log. openedx#2438 (openedx#2445) * Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453) * Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467) * Fix bugs. openedx#2462 openedx#2463 (openedx#2464) * Fix password message in register students page. * Fix glass pane of processing when register additional item. * Fix display width of popup. (openedx#2466) * Fix min-width of sequence-nav. openedx#2468 (openedx#2469) * Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
9 participants
This works adds a language selection menu to a user's dashboard (per UI/feature request found here - https://edx-wiki.atlassian.net/wiki/pages/viewpage.action?pageId=48726317).