Fix unicode error in subsection - #2404
Conversation
|
@sarina For this PR, it's sufficient to add unit tests for just the functions you changed. We should also audit the fixtures used in view-level tests in lms/courseware and add non-ASCII unicode to course names/sections/subsections. This is going to be a longer task -- could you create a ticket in the LMS backlog for this? |
|
👍 |
1 similar comment
|
👍 |
|
thanks @davestgermain ! Tests look great. |
|
oop - hadn't rebased so tests failed. Rebased to pick up fixes. |
|
@sarina I did, too! Fun! |
|
@davestgermain hmmmmm i hope that doesn't cause issues with the branch. I also squashed the two commits as logically they should be - the first commit shouldn't independently pass tests. |
|
@sarina Oh, hmm. Check again; I may have clobbered that squash. I'll just back away slowly... |
|
@davestgermain that's fine. I'm going to let you handle merging this PR - I wasn't sure who should take responsibility since I initially opened it. Squashing would be preferred, I think, but no huge deal this once. |
Fix unicode error in subsection
* Add ORA2 video upload option openedx#2375 (openedx#2417) * Modified courseware page look and feel openedx#2377 (openedx#2409) * Modified about page openedx#2379 (openedx#2413) * Fix biz bugs. openedx#2404 (openedx#2406) * Fix display width of popup. (openedx#2384) (cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95) * Validate duplicate url-code. * Fix bug, when course not found. * Fix order of course as CourseOverview. * Remove additional-info count from contract grid. openedx#2419 (openedx#2437) * Fix order global course. openedx#2420 (openedx#2421) * Add additional info register. openedx#2419 (openedx#2433) * fix survey csv character encode problem openedx#2380 (openedx#2434) * Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457) * Fix register students confirm message. (openedx#2461) * Add command to check playback_log. openedx#2438 (openedx#2445) * Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453) * Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467) * Fix bugs. openedx#2462 openedx#2463 (openedx#2464) * Fix password message in register students page. * Fix glass pane of processing when register additional item. * Fix display width of popup. (openedx#2466) * Fix min-width of sequence-nav. openedx#2468 (openedx#2469) * Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
@chrisndodge this fixes a bug brought up on the mailing list, see my response to this: https://groups.google.com/forum/#!topic/edx-code/cdsQafpz0aA
@wedaly I don't know the best place to add a test for creating a course with sections, subsections, and problem names with Unicode, but obviously this is a needed test! Can you please advise?