chore(inlining): Unit tests for global values and conditional inlining#9411
Merged
chore(inlining): Unit tests for global values and conditional inlining#9411
Conversation
asterite
reviewed
Aug 6, 2025
asterite
approved these changes
Aug 6, 2025
vezenovm
commented
Aug 6, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d22caaf | Previous: 8eeda7e | Ratio |
|---|---|---|---|
private-kernel-inner |
0.02 s |
0.015 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
5 tasks
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d22caaf | Previous: 8eeda7e | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
189 s |
155 s |
1.22 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
asterite
reviewed
Aug 6, 2025
| brillig(inline) fn main f0 { | ||
| b0(): | ||
| v0 = call f1() -> [Field; 2] | ||
| // v1 = array_get g2, index u32 1 -> Field |
Collaborator
There was a problem hiding this comment.
Ah, I forgot to point out this comment too, sorry.
Contributor
Author
There was a problem hiding this comment.
Oops I missed that. We can just remove in some other testing PR
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 11, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: Release Noir(1.0.0-beta.10) (noir-lang/noir#9311) feat(ssa_fuzzer): arrays support (noir-lang/noir#9427) chore: add link to issue on TODOs (noir-lang/noir#8307) fix(ownership): Increment reference count for nested array get in LHS assignment (noir-lang/noir#9347) chore: add some mem2reg unit tests (noir-lang/noir#9405) chore(as_slice_length): Various unit tests (noir-lang/noir#9419) chore(simplify_cfg): Additional unit tests (noir-lang/noir#9426) chore: create directory when writing witness artefact (noir-lang/noir#9383) fix: throw error if foreign call returns the wrong number of fields (noir-lang/noir#9286) chore: update ex in docs (noir-lang/noir#9385) chore: add some `assert_constant` tests (noir-lang/noir#9413) chore: error on non constant inputs for Pedersen generators (noir-lang/noir#9389) chore(inlining): Unit tests for global values and conditional inlining (noir-lang/noir#9411) chore(ssa_fuzzer): refactor fuzzing modes + add fuzzing mode without DIE pass (noir-lang/noir#9401) chore(inlining): Various unit tests (noir-lang/noir#9388) feat(ssa_fuzzer): pushing generated program and witness to redis queue (noir-lang/noir#9375) fix(ssa_gen): Generate code for index before the collection (noir-lang/noir#9332) chore: Regression test for calling a mutable closure inside a mutable closure (noir-lang/noir#9384) fix: some nargo expand fixes (noir-lang/noir#9324) fix: disable comptime printing when requesting json output (noir-lang/noir#9381) chore: address TODO comments (noir-lang/noir#9379) feat: type alias for numeric generics (noir-lang/noir#7583) chore: bump external pinned commits (noir-lang/noir#9291) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Part of the internal audit
Summary*
These are additional unit tests I built while working on the audit for the inlining pass.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.