feat: type alias for numeric generics by guipublic · Pull Request #7583 · noir-lang/noir

guipublic · 2025-03-05T11:22:39Z

Description

Problem*

Resolves #7272

Summary*

Allow type alias to reference numeric generic expression.

Additional Context

Changes are minimal, more use cases need to be tested. In particular there is no documentation. It can be added as a subsequent PR (or even in this one).
The PR is done in order to validate the approach taken.

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

guipublic · 2025-03-05T14:31:49Z

I am not sure why I had to update some unit tests.

compiler/noirc_frontend/src/parser/parser/type_alias.rs

compiler/noirc_frontend/src/ast/type_alias.rs

compiler/noirc_frontend/src/tests.rs

compiler/noirc_frontend/src/ast/type_alias.rs

compiler/noirc_frontend/src/tests.rs

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `06f3cb6`	Previous: `639d802`	Ratio
`test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr`	`4` s	`3` s	`1.33`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib`	`2` s	`1` s	`2`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

compiler/noirc_frontend/src/tests.rs

…rals

guipublic · 2025-07-18T09:24:01Z

@guipublic CI is now passing but I see a lot of error locations shifted here when I think the previous locations were better, so that might need to be fixed.

Thank you!
I improved the location, let me know if there are some cases that I miss.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `309e58d`	Previous: `1719bc3`	Ratio
`rollup-root`	`0.005` s	`0.004` s	`1.25`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

jfecher · 2025-07-18T12:26:14Z

@guipublic looks like there are still some location differences, e.g. on test_noirc_frontend_tests_aliases_disallows_numeric_type_aliases_to_expression_with_alias

guipublic · 2025-07-21T09:26:46Z

@guipublic looks like there are still some location differences, e.g. on test_noirc_frontend_tests_aliases_disallows_numeric_type_aliases_to_expression_with_alias

There was indeed a snapshot issue (now solved).

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `e54ee3d`	Previous: `08995dd`	Ratio
`rollup-root`	`0.005` s	`0.004` s	`1.25`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

compiler/noirc_frontend/src/elaborator/patterns.rs

tooling/nargo_fmt/src/formatter/alias.rs

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: Release Noir(1.0.0-beta.10) (noir-lang/noir#9311) feat(ssa_fuzzer): arrays support (noir-lang/noir#9427) chore: add link to issue on TODOs (noir-lang/noir#8307) fix(ownership): Increment reference count for nested array get in LHS assignment (noir-lang/noir#9347) chore: add some mem2reg unit tests (noir-lang/noir#9405) chore(as_slice_length): Various unit tests (noir-lang/noir#9419) chore(simplify_cfg): Additional unit tests (noir-lang/noir#9426) chore: create directory when writing witness artefact (noir-lang/noir#9383) fix: throw error if foreign call returns the wrong number of fields (noir-lang/noir#9286) chore: update ex in docs (noir-lang/noir#9385) chore: add some `assert_constant` tests (noir-lang/noir#9413) chore: error on non constant inputs for Pedersen generators (noir-lang/noir#9389) chore(inlining): Unit tests for global values and conditional inlining (noir-lang/noir#9411) chore(ssa_fuzzer): refactor fuzzing modes + add fuzzing mode without DIE pass (noir-lang/noir#9401) chore(inlining): Various unit tests (noir-lang/noir#9388) feat(ssa_fuzzer): pushing generated program and witness to redis queue (noir-lang/noir#9375) fix(ssa_gen): Generate code for index before the collection (noir-lang/noir#9332) chore: Regression test for calling a mutable closure inside a mutable closure (noir-lang/noir#9384) fix: some nargo expand fixes (noir-lang/noir#9324) fix: disable comptime printing when requesting json output (noir-lang/noir#9381) chore: address TODO comments (noir-lang/noir#9379) feat: type alias for numeric generics (noir-lang/noir#7583) chore: bump external pinned commits (noir-lang/noir#9291) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

guipublic and others added 2 commits March 5, 2025 11:17

type alias for numeric generics

a1b9b69

Merge branch 'master' into gd/issue_7272

0c2f4ff

guipublic requested a review from a team March 5, 2025 11:23

guipublic changed the title ~~type alias for numeric generics~~ feat: type alias for numeric generics Mar 5, 2025

guipublic and others added 2 commits March 5, 2025 14:30

fix unit tests

82d639e

Merge branch 'master' into gd/issue_7272

ff24516

asterite reviewed Mar 5, 2025

View reviewed changes

compiler/noirc_frontend/src/parser/parser/type_alias.rs Outdated Show resolved Hide resolved

asterite reviewed Mar 5, 2025

View reviewed changes

compiler/noirc_frontend/src/ast/type_alias.rs Outdated Show resolved Hide resolved

asterite reviewed Mar 5, 2025

View reviewed changes

compiler/noirc_frontend/src/ast/type_alias.rs Outdated Show resolved Hide resolved

jfecher reviewed Mar 5, 2025

View reviewed changes

compiler/noirc_frontend/src/tests.rs Outdated Show resolved Hide resolved

guipublic and others added 2 commits March 11, 2025 10:55

use the aliased expression in loop bounds

4d4dabe

Merge branch 'master' into gd/issue_7272

531467a

github-actions bot reviewed Mar 11, 2025

View reviewed changes

guipublic added 3 commits March 11, 2025 11:30

code review: get location before parsing semi-column

8f50d5e

code review

249f71b

Code Review: use option instead of an enum

ca3298f

TomAFrench reviewed Mar 11, 2025

View reviewed changes

compiler/noirc_frontend/src/tests.rs Outdated Show resolved Hide resolved

guipublic and others added 11 commits March 11, 2025 17:02

Code review

7884d9f

Merge branch 'master' into gd/issue_7272

e19f7e3

rename typealias

6739cc9

Merge branch 'master' into gd/issue_7272

7b79b8a

Disable numeric type alias composition

c5e1dcc

Merge branch 'master' into gd/issue_7272

0074169

remove 'custom errors span' in test as it conflict with negative lite…

44abde3

…rals

Merge branch 'master' into gd/issue_7272

e04ad34

format

97b7063

remove custom error spans from test, completely

faf9f0c

add integration test

efcecff

better location for numeric expression in type alias

309e58d

github-actions bot reviewed Jul 18, 2025

View reviewed changes

guipublic and others added 2 commits July 21, 2025 11:23

snapshots

e54ee3d

Merge branch 'master' into gd/issue_7272

20d2478

github-actions bot reviewed Jul 21, 2025

View reviewed changes

asterite added 2 commits July 21, 2025 12:02

Merge branch 'master' into gd/issue_7272

3c4c46b

Handle UnresolvedTypeData::AsTraitPath

0697813

asterite reviewed Jul 21, 2025

View reviewed changes

compiler/noirc_frontend/src/elaborator/patterns.rs Outdated Show resolved Hide resolved

asterite reviewed Jul 21, 2025

View reviewed changes

compiler/noirc_frontend/src/elaborator/patterns.rs Outdated Show resolved Hide resolved

asterite reviewed Jul 21, 2025

View reviewed changes

compiler/noirc_frontend/src/elaborator/patterns.rs Outdated Show resolved Hide resolved

asterite reviewed Jul 21, 2025

View reviewed changes

tooling/nargo_fmt/src/formatter/alias.rs Show resolved Hide resolved

guipublic added 2 commits July 29, 2025 11:35

code review

2a96dce

Merge branch 'master' into gd/issue_7272

826bfca

jfecher approved these changes Jul 29, 2025

View reviewed changes

guipublic added 5 commits August 1, 2025 18:20

Merge branch 'master' into gd/issue_7272

61f3d2c

fix build

251d89b

snapshots

5e42487

Merge branch 'master' into gd/issue_7272

62cf332

format

06f3cb6

guipublic added this pull request to the merge queue Aug 4, 2025

Merged via the queue into master with commit d7e2c17 Aug 4, 2025
101 checks passed

guipublic deleted the gd/issue_7272 branch August 4, 2025 10:05

noirwhal mentioned this pull request Aug 4, 2025

chore: Release Noir(1.0.0-beta.10) #9311

Merged

AztecBot mentioned this pull request Aug 5, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#16204

Merged

Savio-Sou mentioned this pull request Aug 19, 2025

Document type alias for numeric generics #9568

Closed

Conversation

guipublic commented Mar 5, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

guipublic commented Mar 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

guipublic commented Jul 18, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

jfecher commented Jul 18, 2025

Uh oh!

guipublic commented Jul 21, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot left a comment •

edited

Loading