chore: Regression test for calling a mutable closure inside a mutable closure#9384
Merged
chore: Regression test for calling a mutable closure inside a mutable closure#9384
Conversation
vezenovm
commented
Aug 4, 2025
test_programs/compile_success_empty/call_mut_closure_inside_mut_closure/src/main.nr
Outdated
Show resolved
Hide resolved
…t_closure/src/main.nr
jfecher
approved these changes
Aug 4, 2025
asterite
approved these changes
Aug 4, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 11, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: Release Noir(1.0.0-beta.10) (noir-lang/noir#9311) feat(ssa_fuzzer): arrays support (noir-lang/noir#9427) chore: add link to issue on TODOs (noir-lang/noir#8307) fix(ownership): Increment reference count for nested array get in LHS assignment (noir-lang/noir#9347) chore: add some mem2reg unit tests (noir-lang/noir#9405) chore(as_slice_length): Various unit tests (noir-lang/noir#9419) chore(simplify_cfg): Additional unit tests (noir-lang/noir#9426) chore: create directory when writing witness artefact (noir-lang/noir#9383) fix: throw error if foreign call returns the wrong number of fields (noir-lang/noir#9286) chore: update ex in docs (noir-lang/noir#9385) chore: add some `assert_constant` tests (noir-lang/noir#9413) chore: error on non constant inputs for Pedersen generators (noir-lang/noir#9389) chore(inlining): Unit tests for global values and conditional inlining (noir-lang/noir#9411) chore(ssa_fuzzer): refactor fuzzing modes + add fuzzing mode without DIE pass (noir-lang/noir#9401) chore(inlining): Various unit tests (noir-lang/noir#9388) feat(ssa_fuzzer): pushing generated program and witness to redis queue (noir-lang/noir#9375) fix(ssa_gen): Generate code for index before the collection (noir-lang/noir#9332) chore: Regression test for calling a mutable closure inside a mutable closure (noir-lang/noir#9384) fix: some nargo expand fixes (noir-lang/noir#9324) fix: disable comptime printing when requesting json output (noir-lang/noir#9381) chore: address TODO comments (noir-lang/noir#9379) feat: type alias for numeric generics (noir-lang/noir#7583) chore: bump external pinned commits (noir-lang/noir#9291) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #5545
Summary*
Going through existing inlining bugs and found this one that looks to be passing now.
We now appropriately compile to an empty program for the snippet in #5545. This PR simply adds the test as a regression. Hitting the recursion limit error (previously a panic as per the issue) is unexpected and it looks like the compiler now correctly handles this case (there have been updates to both defunctionalization and inlining since this issue was created).
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.