Skip to content

chore(inlining): Various unit tests#9388

Merged
vezenovm merged 6 commits intomasterfrom
mv/inlining-unit-tests
Aug 5, 2025
Merged

chore(inlining): Various unit tests#9388
vezenovm merged 6 commits intomasterfrom
mv/inlining-unit-tests

Conversation

@vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Aug 4, 2025

Description

Problem*

No issue, just noticed we were missing unit tests for various logic in our inlining pass.

Summary*

All unit tests added in this PR are passing as expected.
Additional tests in inlining and inline info computation:

  • Preventing inlining Brillig into ACIR
  • Inlining functions containing static assertions
  • Inlining no predicates with and without the config flag active
  • #[inline_always] attribute

CallGraph tests:

  • Multiple recursive cycles
  • Additional self recursion checks
  • Dead code tracked in call graph

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested review from a team and asterite August 4, 2025 16:43
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: c50821e Previous: 532b512 Ratio
rollup-block-root-single-tx 246 s 201 s 1.22

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: c50821e Previous: 532b512 Ratio
test_report_zkpassport_noir_rsa_ 1 s 0 s +∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

vezenovm and others added 2 commits August 5, 2025 09:17
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@vezenovm vezenovm enabled auto-merge August 5, 2025 14:34
@vezenovm vezenovm added this pull request to the merge queue Aug 5, 2025
Merged via the queue into master with commit b2713a9 Aug 5, 2025
122 checks passed
@vezenovm vezenovm deleted the mv/inlining-unit-tests branch August 5, 2025 15:17
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 11, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: Release Noir(1.0.0-beta.10)
(noir-lang/noir#9311)
feat(ssa_fuzzer): arrays support
(noir-lang/noir#9427)
chore: add link to issue on TODOs
(noir-lang/noir#8307)
fix(ownership): Increment reference count for nested array get in LHS
assignment (noir-lang/noir#9347)
chore: add some mem2reg unit tests
(noir-lang/noir#9405)
chore(as_slice_length): Various unit tests
(noir-lang/noir#9419)
chore(simplify_cfg): Additional unit tests
(noir-lang/noir#9426)
chore: create directory when writing witness artefact
(noir-lang/noir#9383)
fix: throw error if foreign call returns the wrong number of fields
(noir-lang/noir#9286)
chore: update ex in docs (noir-lang/noir#9385)
chore: add some `assert_constant` tests
(noir-lang/noir#9413)
chore: error on non constant inputs for Pedersen generators
(noir-lang/noir#9389)
chore(inlining): Unit tests for global values and conditional inlining
(noir-lang/noir#9411)
chore(ssa_fuzzer): refactor fuzzing modes + add fuzzing mode without DIE
pass (noir-lang/noir#9401)
chore(inlining): Various unit tests
(noir-lang/noir#9388)
feat(ssa_fuzzer): pushing generated program and witness to redis queue
(noir-lang/noir#9375)
fix(ssa_gen): Generate code for index before the collection
(noir-lang/noir#9332)
chore: Regression test for calling a mutable closure inside a mutable
closure (noir-lang/noir#9384)
fix: some nargo expand fixes
(noir-lang/noir#9324)
fix: disable comptime printing when requesting json output
(noir-lang/noir#9381)
chore: address TODO comments
(noir-lang/noir#9379)
feat: type alias for numeric generics
(noir-lang/noir#7583)
chore: bump external pinned commits
(noir-lang/noir#9291)
END_COMMIT_OVERRIDE

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants