Skip to content

chore: add link to issue on TODOs#8307

Merged
TomAFrench merged 7 commits intomasterfrom
tf/add-issues-for-todos
Aug 8, 2025
Merged

chore: add link to issue on TODOs#8307
TomAFrench merged 7 commits intomasterfrom
tf/add-issues-for-todos

Conversation

@TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR is a branch to accumulate adding links to various issues which correspond to TODOs in the code.

cc @michaeljklein

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: e170316 Previous: f31097d Ratio
regression_4709 0.871 s 0.693 s 1.26
global_var_regression_entry_points 0.642 s 0.501 s 1.28

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench TomAFrench merged commit b7406ba into master Aug 8, 2025
33 checks passed
@TomAFrench TomAFrench deleted the tf/add-issues-for-todos branch August 8, 2025 11:54
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 533577c Previous: 20c37b2 Ratio
test_report_zkpassport_noir-ecdsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 11, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: Release Noir(1.0.0-beta.10)
(noir-lang/noir#9311)
feat(ssa_fuzzer): arrays support
(noir-lang/noir#9427)
chore: add link to issue on TODOs
(noir-lang/noir#8307)
fix(ownership): Increment reference count for nested array get in LHS
assignment (noir-lang/noir#9347)
chore: add some mem2reg unit tests
(noir-lang/noir#9405)
chore(as_slice_length): Various unit tests
(noir-lang/noir#9419)
chore(simplify_cfg): Additional unit tests
(noir-lang/noir#9426)
chore: create directory when writing witness artefact
(noir-lang/noir#9383)
fix: throw error if foreign call returns the wrong number of fields
(noir-lang/noir#9286)
chore: update ex in docs (noir-lang/noir#9385)
chore: add some `assert_constant` tests
(noir-lang/noir#9413)
chore: error on non constant inputs for Pedersen generators
(noir-lang/noir#9389)
chore(inlining): Unit tests for global values and conditional inlining
(noir-lang/noir#9411)
chore(ssa_fuzzer): refactor fuzzing modes + add fuzzing mode without DIE
pass (noir-lang/noir#9401)
chore(inlining): Various unit tests
(noir-lang/noir#9388)
feat(ssa_fuzzer): pushing generated program and witness to redis queue
(noir-lang/noir#9375)
fix(ssa_gen): Generate code for index before the collection
(noir-lang/noir#9332)
chore: Regression test for calling a mutable closure inside a mutable
closure (noir-lang/noir#9384)
fix: some nargo expand fixes
(noir-lang/noir#9324)
fix: disable comptime printing when requesting json output
(noir-lang/noir#9381)
chore: address TODO comments
(noir-lang/noir#9379)
feat: type alias for numeric generics
(noir-lang/noir#7583)
chore: bump external pinned commits
(noir-lang/noir#9291)
END_COMMIT_OVERRIDE

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants