chore(docs): Defunctionalization and some minor cleanup by vezenovm · Pull Request #8217 · noir-lang/noir

vezenovm · 2025-04-24T19:51:52Z

Description

Problem*

Resolves #8153

Summary*

I have added doc comments through the defunctionalization pass.

While going through the pass I found that the build_return_block logic when building an apply function was unnecessarily confusing. We were checking whether to build the return block for every function variant when we were building the if-else chain of function variant calls. We can just build it a single time and simplify the logic here.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…turn block logic:

compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `31686be`	Previous: `114c06c`	Ratio
`rollup-merge`	`1.112` s	`0.887` s	`1.25`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `31686be`	Previous: `114c06c`	Ratio
`rollup-merge`	`0.005` s	`0.004` s	`1.25`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>

vezenovm added 2 commits April 24, 2025 19:48

documentation for defunctionalize as well some cleanup surrounding re…

d2f7942

…turn block logic:

cleanup

31686be

vezenovm commented Apr 24, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs Outdated Show resolved Hide resolved

Update compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs

045af62

github-actions bot reviewed Apr 24, 2025

View reviewed changes

vezenovm requested a review from a team April 24, 2025 20:38

TomAFrench reviewed Apr 24, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs Outdated Show resolved Hide resolved

compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs Outdated Show resolved Hide resolved

compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs Show resolved Hide resolved

vezenovm and others added 3 commits April 24, 2025 17:02

Update compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs

2c31eb1

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

Update compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs

878b38d

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

Update compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs

e0cf562

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

TomAFrench approved these changes Apr 25, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Apr 25, 2025

Merged via the queue into master with commit a4857eb Apr 25, 2025
114 checks passed

TomAFrench deleted the mv/defunctionalize-docs branch April 25, 2025 10:17

AztecBot mentioned this pull request Apr 26, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#13781

Merged

AztecBot mentioned this pull request Apr 28, 2025

chore(master): release 0.87.0 AztecProtocol/aztec-packages#13800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(docs): Defunctionalization and some minor cleanup#8217

chore(docs): Defunctionalization and some minor cleanup#8217
TomAFrench merged 6 commits intomasterfrom
mv/defunctionalize-docs

vezenovm commented Apr 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vezenovm commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vezenovm commented Apr 24, 2025 •

edited

Loading