fix: returns 0 for right shift overflow by guipublic · Pull Request #8189 · noir-lang/noir

guipublic · 2025-04-23T17:14:42Z

Description

Problem*

Resolve #8176

Summary*

Ensure that we return 0 in case of right shift overflow, also for Brillig.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2025-04-23T17:20:20Z

Changes to circuit sizes

Generated at commit: d81767f7df1e1de55d8e1d8161da2a9fceaf9c59, compared to commit: b41112159d86863fc4d582ffd461a018639e2de5

🧾 Summary (10% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
bit_shifts_runtime	+167 ❌	+56.23%	+195 ❌	+4.89%
u128_type	+38 ❌	+25.85%	+53 ❌	+1.15%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
bit_shifts_runtime	464 (+167)	+56.23%	4,180 (+195)	+4.89%
u128_type	185 (+38)	+25.85%	4,668 (+53)	+1.15%
shift_right_overflow	52 (-1)	-1.89%	2,866 (0)	0.00%

github-actions · 2025-04-23T17:20:25Z

Changes to Brillig bytecode sizes

Generated at commit: d81767f7df1e1de55d8e1d8161da2a9fceaf9c59, compared to commit: b41112159d86863fc4d582ffd461a018639e2de5

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
bit_shifts_runtime_inliner_max	+139 ❌	+51.48%
bit_shifts_runtime_inliner_min	+139 ❌	+51.48%
bit_shifts_runtime_inliner_zero	+139 ❌	+51.48%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
bit_shifts_runtime_inliner_max	409 (+139)	+51.48%
bit_shifts_runtime_inliner_min	409 (+139)	+51.48%
bit_shifts_runtime_inliner_zero	409 (+139)	+51.48%

github-actions · 2025-04-24T10:54:43Z

Changes to number of Brillig opcodes executed

Generated at commit: d81767f7df1e1de55d8e1d8161da2a9fceaf9c59, compared to commit: b41112159d86863fc4d582ffd461a018639e2de5

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
bit_shifts_runtime_inliner_max	+32 ❌	+19.75%
bit_shifts_runtime_inliner_min	+32 ❌	+19.75%
bit_shifts_runtime_inliner_zero	+32 ❌	+19.75%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
bit_shifts_runtime_inliner_max	194 (+32)	+19.75%
bit_shifts_runtime_inliner_min	194 (+32)	+19.75%
bit_shifts_runtime_inliner_zero	194 (+32)	+19.75%

asterite

Looks good!

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>

returns 0 for right shift overflow

90f625d

guipublic requested a review from asterite April 23, 2025 17:14

Merge branch 'master' into gd/issue_8176

b8b6a76

guipublic and others added 2 commits April 24, 2025 10:50

return 0 if shr overflow in brillig

1900b36

Merge branch 'master' into gd/issue_8176

28681ff

guipublic and others added 2 commits April 24, 2025 11:28

snapshots

d8e5c98

Merge branch 'master' into gd/issue_8176

dde3bcb

asterite approved these changes Apr 24, 2025

View reviewed changes

asterite added this pull request to the merge queue Apr 24, 2025

Merged via the queue into master with commit 13158f3 Apr 24, 2025
114 checks passed

asterite deleted the gd/issue_8176 branch April 24, 2025 12:21

noirwhal mentioned this pull request Apr 24, 2025

chore: Release Noir(1.0.0-beta.5) #7955

Merged

AztecBot mentioned this pull request Apr 25, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#13781

Merged

AztecBot mentioned this pull request Apr 28, 2025

chore(master): release 0.87.0 AztecProtocol/aztec-packages#13800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: returns 0 for right shift overflow#8189

fix: returns 0 for right shift overflow#8189
asterite merged 6 commits intomasterfrom
gd/issue_8176

guipublic commented Apr 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 24, 2025 •

edited

Loading

Uh oh!

asterite left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

guipublic commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to circuit sizes

🧾 Summary (10% most significant diffs)

Uh oh!

github-actions bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to Brillig bytecode sizes

🧾 Summary (10% most significant diffs)

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to number of Brillig opcodes executed

🧾 Summary (10% most significant diffs)

Uh oh!

asterite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guipublic commented Apr 23, 2025 •

edited

Loading

github-actions bot commented Apr 23, 2025 •

edited

Loading

github-actions bot commented Apr 23, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading