feat(greybox_fuzzer): Should_fail and should_fail_with by Rumata888 · Pull Request #8118 · noir-lang/noir

Rumata888 · 2025-04-17T12:33:26Z

Updated error messages in the lexer to include new fuzz attribute forms.
Modified parser to recognize and handle should_fail and should_fail_with attributes.
Added new test programs to validate the behavior of these attributes.
Enhanced the fuzzer to support expected failure scenarios based on the new attributes
Added parsing of partial witness to detect triggered boolean conditions under "should_fail*" scenarios

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…with` options - Updated error messages in the lexer to include new fuzz attribute forms. - Modified parser to recognize and handle `should_fail` and `should_fail_with` attributes. - Added new test programs to validate the behavior of these attributes. - Enhanced the fuzzer to support expected failure scenarios based on the new attributes.

tooling/greybox_fuzzer/src/coverage.rs

tooling/greybox_fuzzer/src/lib.rs

github-actions · 2025-04-23T11:33:47Z

🚀 Deployed on https://6809058038097c185ebe0272--noir-docs.netlify.app

tooling/greybox_fuzzer/src/lib.rs

asterite

Looks great! I left a final comment.

github-actions · 2025-04-23T15:21:52Z

FYI @noir-lang/developerrelations on Noir doc changes.

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>

Rumata888 added 2 commits April 17, 2025 12:32

wip

b9cbff2

Rumata888 self-assigned this Apr 17, 2025

Rumata888 changed the title ~~Is/fuzzing_always_fails~~ feat(greybox_fuzzer): Should_fail and should_fail_with Apr 17, 2025

Rumata888 added 6 commits April 17, 2025 12:38

clippy

4147db2

format

c269b65

partial witnesses work

c6e9a3d

clippy

9ac95b0

partial witness test

3e2fbf9

small cleanup

f238ff2

TomAFrench requested a review from asterite April 22, 2025 16:22

asterite reviewed Apr 22, 2025

View reviewed changes

tooling/greybox_fuzzer/src/coverage.rs Outdated Show resolved Hide resolved

asterite reviewed Apr 22, 2025

View reviewed changes

tooling/greybox_fuzzer/src/lib.rs Outdated Show resolved Hide resolved

asterite reviewed Apr 22, 2025

View reviewed changes

tooling/greybox_fuzzer/src/lib.rs Show resolved Hide resolved

docs

78da731

github-actions bot added the documentation Improvements or additions to documentation label Apr 23, 2025

Rumata888 added 2 commits April 23, 2025 14:30

Address Ary's comments

ce5a4f4

Merge branch 'master' into is/fuzzing_always_fails

ec468de

Rumata888 requested a review from asterite April 23, 2025 14:48

asterite reviewed Apr 23, 2025

View reviewed changes

tooling/greybox_fuzzer/src/lib.rs Outdated Show resolved Hide resolved

asterite approved these changes Apr 23, 2025

View reviewed changes

address comments

566d1e7

Rumata888 enabled auto-merge April 23, 2025 15:18

Rumata888 added this pull request to the merge queue Apr 23, 2025

Merged via the queue into master with commit 4c4bee7 Apr 23, 2025
114 checks passed

Rumata888 deleted the is/fuzzing_always_fails branch April 23, 2025 15:40

noirwhal mentioned this pull request Apr 23, 2025

chore: Release Noir(1.0.0-beta.5) #7955

Merged

Rumata888 mentioned this pull request Apr 23, 2025

Return partial generated witness for ACIR on failure for the greybox fuzzer #7502

Closed

AztecBot mentioned this pull request Apr 24, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#13781

Merged

AztecBot mentioned this pull request Apr 28, 2025

chore(master): release 0.87.0 AztecProtocol/aztec-packages#13800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(greybox_fuzzer): Should_fail and should_fail_with#8118

feat(greybox_fuzzer): Should_fail and should_fail_with#8118
Rumata888 merged 12 commits intomasterfrom
is/fuzzing_always_fails

Rumata888 commented Apr 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

asterite left a comment

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Rumata888 commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

asterite left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rumata888 commented Apr 17, 2025 •

edited

Loading

github-actions bot commented Apr 23, 2025 •

edited

Loading