Conversation
Contributor
Compilation Memory Report
|
Contributor
Execution Memory Report
|
Contributor
Execution Report
|
Contributor
Compilation Report
|
Member
|
Merging in master to compare artifact sizes in aztec-packages. |
Member
|
Nice, this drops the artifact size of |
TomAFrench
reviewed
Jan 15, 2025
TomAFrench
reviewed
Jan 15, 2025
TomAFrench
reviewed
Jan 15, 2025
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
Forgot to hit send on these comments.
Also aztec-packages has their own homebrew method of dealing with debug info in their simulator which is this is definitely going to break. Can you take a look at what this will take to update?
compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: 5f4e39c | Previous: 20fdf4c | Ratio |
|---|---|---|---|
private-kernel-inner |
203.28 MB |
209.58 MB |
0.97 |
private-kernel-reset |
227.03 MB |
246.67 MB |
0.92 |
private-kernel-tail |
181.3 MB |
183.72 MB |
0.99 |
rollup-base-private |
433.5 MB |
488.55 MB |
0.89 |
rollup-base-public |
425.68 MB |
464.53 MB |
0.92 |
rollup-block-root |
1420 MB |
1710 MB |
0.83 |
rollup-merge |
254.29 MB |
254.71 MB |
1.00 |
rollup-root |
260.03 MB |
261.28 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: 5f4e39c | Previous: 20fdf4c | Ratio |
|---|---|---|---|
private-kernel-inner |
270.81 MB |
270.84 MB |
1.00 |
private-kernel-reset |
535.37 MB |
551.13 MB |
0.97 |
private-kernel-tail |
200.13 MB |
200.14 MB |
1.00 |
rollup-base-private |
1330 MB |
1330 MB |
1 |
rollup-base-public |
1350 MB |
1350 MB |
1 |
rollup-block-root-empty |
270.76 MB |
270.77 MB |
1.00 |
rollup-block-root-single-tx |
7770 MB |
7770 MB |
1 |
rollup-block-root |
7780 MB |
7780 MB |
1 |
rollup-merge |
271.95 MB |
271.94 MB |
1.00 |
rollup-root |
322.45 MB |
322.44 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: b9b55e4 | Previous: 17958e3 | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
267857 ns/iter (± 1475) |
267597 ns/iter (± 357) |
1.00 |
perfectly_parallel_opcodes |
235454 ns/iter (± 2540) |
239120 ns/iter (± 1856) |
0.98 |
perfectly_parallel_batch_inversion_opcodes |
3586399 ns/iter (± 16246) |
3224732 ns/iter (± 5543) |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: b9b55e4 | Previous: 17958e3 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.03 s |
0.028 s |
1.07 |
private-kernel-reset |
0.164 s |
0.164 s |
1 |
private-kernel-tail |
0.016 s |
0.017 s |
0.94 |
rollup-base-private |
0.328 s |
0.339 s |
0.97 |
rollup-base-public |
0.215 s |
0.225 s |
0.96 |
rollup-block-root |
11.1 s |
11.5 s |
0.97 |
rollup-merge |
0.004 s |
0.004 s |
1 |
rollup-root |
0.013 s |
0.014 s |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: b9b55e4 | Previous: 17958e3 | Ratio |
|---|---|---|---|
regression_4709 |
0.634 s |
0.687 s |
0.92 |
ram_blowup_regression |
12.6 s |
13.1 s |
0.96 |
global_var_regression_entry_points |
0.456 s |
0.471 s |
0.97 |
private-kernel-inner |
2.208 s |
2.302 s |
0.96 |
private-kernel-reset |
6.264 s |
6.77 s |
0.93 |
private-kernel-tail |
1.024 s |
1.068 s |
0.96 |
rollup-base-private |
16.18 s |
17.92 s |
0.90 |
rollup-base-public |
12.56 s |
14.54 s |
0.86 |
rollup-block-root-empty |
0.88 s |
0.877 s |
1.00 |
rollup-block-root-single-tx |
122 s |
126 s |
0.97 |
rollup-block-root |
126 s |
122 s |
1.03 |
rollup-merge |
0.89 s |
0.895 s |
0.99 |
rollup-root |
1.352 s |
1.472 s |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: b9b55e4 | Previous: 17958e3 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
49 s |
50 s |
0.98 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
94 s |
88 s |
1.07 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
40 s |
37 s |
1.08 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib |
158 s |
161 s |
0.98 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
51 s |
51 s |
1 |
test_report_noir-lang_sha512_ |
30 s |
27 s |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: 2020eda | Previous: 17958e3 | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
262924 ns/iter (± 5021) |
267597 ns/iter (± 357) |
0.98 |
perfectly_parallel_opcodes |
232586 ns/iter (± 6944) |
239120 ns/iter (± 1856) |
0.97 |
perfectly_parallel_batch_inversion_opcodes |
3223681 ns/iter (± 23228) |
3224732 ns/iter (± 5543) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: 2020eda | Previous: 17958e3 | Ratio |
|---|---|---|---|
regression_4709 |
0.664 s |
0.687 s |
0.97 |
ram_blowup_regression |
12.7 s |
13.1 s |
0.97 |
global_var_regression_entry_points |
0.454 s |
0.471 s |
0.96 |
private-kernel-inner |
2.236 s |
2.302 s |
0.97 |
private-kernel-reset |
6.234 s |
6.77 s |
0.92 |
private-kernel-tail |
1.044 s |
1.068 s |
0.98 |
rollup-base-private |
16.62 s |
17.92 s |
0.93 |
rollup-base-public |
12.62 s |
14.54 s |
0.87 |
rollup-block-root-empty |
0.862 s |
0.877 s |
0.98 |
rollup-block-root-single-tx |
119 s |
126 s |
0.94 |
rollup-block-root |
126 s |
122 s |
1.03 |
rollup-merge |
0.842 s |
0.895 s |
0.94 |
rollup-root |
1.458 s |
1.472 s |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: 2020eda | Previous: 17958e3 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.028 s |
0.028 s |
1 |
private-kernel-reset |
0.162 s |
0.164 s |
0.99 |
private-kernel-tail |
0.017 s |
0.017 s |
1 |
rollup-base-private |
0.332 s |
0.339 s |
0.98 |
rollup-base-public |
0.213 s |
0.225 s |
0.95 |
rollup-block-root |
11.4 s |
11.5 s |
0.99 |
rollup-merge |
0.004 s |
0.004 s |
1 |
rollup-root |
0.013 s |
0.014 s |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: b9b55e4 | Previous: 17958e3 | Ratio |
|---|---|---|---|
private-kernel-inner |
270.8 MB |
270.79 MB |
1.00 |
private-kernel-reset |
535.37 MB |
551.13 MB |
0.97 |
private-kernel-tail |
200.13 MB |
200.14 MB |
1.00 |
rollup-base-private |
1330 MB |
1330 MB |
1 |
rollup-base-public |
1350 MB |
1350 MB |
1 |
rollup-block-root-empty |
270.77 MB |
270.76 MB |
1.00 |
rollup-block-root-single-tx |
7770 MB |
7770 MB |
1 |
rollup-block-root |
7780 MB |
7780 MB |
1 |
rollup-merge |
271.95 MB |
271.94 MB |
1.00 |
rollup-root |
322.47 MB |
322.44 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: b9b55e4 | Previous: 17958e3 | Ratio |
|---|---|---|---|
private-kernel-inner |
203.28 MB |
209.58 MB |
0.97 |
private-kernel-reset |
227.03 MB |
246.67 MB |
0.92 |
private-kernel-tail |
181.3 MB |
183.72 MB |
0.99 |
rollup-base-private |
433.5 MB |
488.55 MB |
0.89 |
rollup-base-public |
425.68 MB |
464.53 MB |
0.92 |
rollup-block-root |
1420 MB |
1710 MB |
0.83 |
rollup-merge |
254.29 MB |
254.71 MB |
1.00 |
rollup-root |
260.03 MB |
261.28 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: 2020eda | Previous: 17958e3 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
51 s |
50 s |
1.02 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
94 s |
88 s |
1.07 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
37 s |
37 s |
1 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
168 s |
170 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib |
154 s |
161 s |
0.96 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
54 s |
51 s |
1.06 |
test_report_noir-lang_noir-bignum_ |
412 s |
426 s |
0.97 |
test_report_noir-lang_noir_bigcurve_ |
228 s |
246 s |
0.93 |
test_report_noir-lang_sha512_ |
27 s |
27 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: 2020eda | Previous: 17958e3 | Ratio |
|---|---|---|---|
private-kernel-inner |
203.28 MB |
209.58 MB |
0.97 |
private-kernel-reset |
227.03 MB |
246.67 MB |
0.92 |
private-kernel-tail |
181.3 MB |
183.72 MB |
0.99 |
rollup-base-private |
433.5 MB |
488.55 MB |
0.89 |
rollup-base-public |
425.68 MB |
464.53 MB |
0.92 |
rollup-block-root |
1420 MB |
1710 MB |
0.83 |
rollup-merge |
254.29 MB |
254.71 MB |
1.00 |
rollup-root |
260.03 MB |
261.28 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: 2020eda | Previous: 17958e3 | Ratio |
|---|---|---|---|
private-kernel-inner |
270.76 MB |
270.79 MB |
1.00 |
private-kernel-reset |
535.37 MB |
551.13 MB |
0.97 |
private-kernel-tail |
200.13 MB |
200.14 MB |
1.00 |
rollup-base-private |
1330 MB |
1330 MB |
1 |
rollup-base-public |
1350 MB |
1350 MB |
1 |
rollup-block-root-empty |
270.75 MB |
270.76 MB |
1.00 |
rollup-block-root-single-tx |
7770 MB |
7770 MB |
1 |
rollup-block-root |
7780 MB |
7780 MB |
1 |
rollup-merge |
271.93 MB |
271.94 MB |
1.00 |
rollup-root |
322.47 MB |
322.44 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 28, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 28, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 28, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6946
Summary*
Adds the location tree to debug info and reference call-stacks through their 'index' in the tree (i.e a node of the tree).
Additional Context
The location tree is merged from ACIR location tree and brillig per function location trees.
N.B In case of several ACIR functions, we get several location trees (one per function). These trees could be merged, but this can be done in a follow-up PR.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.