chore: enable '--pedantic-solving' on more tests by michaeljklein · Pull Request #7701 · noir-lang/noir

michaeljklein · 2025-03-13T19:29:48Z

Description

Problem*

Unblocks AztecProtocol/aztec-packages#11224

Summary*

Currently blocked by:

~~Quadrupling embedded curve points produces infinite result only in Brillig w/ inliner aggressiveness 0 #7749~~
~~fix: proper use of add_unsafe in unconstrained #7816~~

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…l' test

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `7481a46`	Previous: `def2e8c`	Ratio
`olehmisar_noir_webauthn_`	`2` s	`1` s	`2`
`zkemail_noir-jwt_`	`5` s	`2` s	`2.50`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

…ternal repo checks

tooling/nargo_cli/tests/snapshots/execute__tests__strings_force_brillig_true_inliner_0.snap

…de '--pedantic-solving'

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: let `nargo test` use the new greybox fuzzer (noir-lang/noir#8234) chore(docs): add fixed bugs to list (noir-lang/noir#8201) fix(parser): do not use `Ident::default()` (noir-lang/noir#8224) feat(fuzz): Add experimental comptime code generator (noir-lang/noir#8207) fix: let SSA parser parse calls to print (noir-lang/noir#8232) feat: added 1, -1 case for inversions in brillig (noir-lang/noir#8225) chore: clippy (noir-lang/noir#8220) fix: don't take implicitly added named generics when checking where clauses (noir-lang/noir#8184) chore(docs): Defunctionalization and some minor cleanup (noir-lang/noir#8217) feat: add `--no-fuzz` and `--only-fuzz` to `nargo test` (noir-lang/noir#8213) chore: add regression test for panic encountered in bigcurve library. (noir-lang/noir#8211) fix: validate numeric types when passing them to a FunctionBuilder (noir-lang/noir#8215) chore: refactor constrainedness checks on trait impls (noir-lang/noir#8170) chore(test): Add smoke test for AST generation (noir-lang/noir#8048) chore: bump more dependencies (noir-lang/noir#8208) chore: Don't use `i1` in the AST fuzzer (noir-lang/noir#8204) fix: Do not panic if RHS constant in division has more bits than the operand (noir-lang/noir#8197) chore: bump cargo deps (noir-lang/noir#8205) fix: Handle truncating constants to 128 bits (noir-lang/noir#8180) fix!: disallow the `i1` type (noir-lang/noir#8172) chore(fuzz): Make sure `main` makes at least one call (noir-lang/noir#8202) fix: Use `get_local_or_global_instruction` in `try_optimize_array_set_from_previous_get` (noir-lang/noir#8200) fix: returns 0 for right shift overflow (noir-lang/noir#8189) feat: avoid overflow check when subtracting from a value that is the maximum for its bitsize (noir-lang/noir#8190) feat: optimize `checked_to_unchecked` to take into account multiplications (noir-lang/noir#8188) chore: document ssa `inline_simple_functions` (noir-lang/noir#8169) chore(docs): remove_unreachable SSA pass (noir-lang/noir#8196) chore: Change AST fuzzer recursion limit (noir-lang/noir#8173) chore(acir): Unify how we display witness indices (noir-lang/noir#8192) fix: Detect ABI change of fuzzing harnesses (noir-lang/noir#8193) chore(acir): Test that `BLACKBOX::RANGE` display the number of bits (noir-lang/noir#8191) fix(debugger): send idle at loop end + fix test (noir-lang/noir#8187) fix: Use `get_local_or_global_instruction` when simplifying `IfElse` (noir-lang/noir#8185) fix(parser): avoid using `Location::dummy()` (noir-lang/noir#8178) chore: Push a bug list (noir-lang/noir#8186) feat(greybox_fuzzer): Should_fail and should_fail_with (noir-lang/noir#8118) chore: move unsigned overflow check from acir/brillig to ssa (noir-lang/noir#8163) feat: location tree for debug_info (noir-lang/noir#7034) fix: Use `IntegerConstant` for loop boundaries in `unrolling` (noir-lang/noir#8094) fix(ssa): Recursive shared Brillig entry points (noir-lang/noir#8099) chore: enable '--pedantic-solving' on more tests (noir-lang/noir#7701) chore(readme): Update `acvm-repo` READMEs (noir-lang/noir#8150) chore(test): add `test_programs` dir for expected-panic tests (noir-lang/noir#8147) chore(docs): minor updates in solidity doc (noir-lang/noir#8160) feat(debugger): debug test functions (noir-lang/noir#7958) chore: migrate recursive proof test to ultrahonk (noir-lang/noir#8038) chore: bump glob package (noir-lang/noir#8159) chore: bump external pinned commits (noir-lang/noir#8139) chore(docs): patch web app tutorial in 1.0.0-beta3 versioned docs (noir-lang/noir#8158) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: TomAFrench <tom@tomfren.ch>

michaeljklein and others added 4 commits March 13, 2025 15:23

chore: enable '--pedantic-solving' on more tests

ab14251

Merge branch 'master' into michaeljklein/pedantic-flag-tests

28efc12

accumulate to zero instead of 'point_at_infinity' in 'multi_scalar_mu…

49515fe

…l' test

Merge branch 'master' into michaeljklein/pedantic-flag-tests

1ccd346

michaeljklein mentioned this pull request Mar 19, 2025

Quadrupling embedded curve points produces infinite result only in Brillig w/ inliner aggressiveness 0 #7749

Closed

Merge branch 'master' into michaeljklein/pedantic-flag-tests

81d026e

github-actions bot reviewed Mar 25, 2025

View reviewed changes

michaeljklein and others added 15 commits March 25, 2025 17:03

patch 'multi_scalar_mul' execution test w/ 'accumulator = 1'

99dc97d

Merge branch 'master' into michaeljklein/pedantic-flag-tests

db529c4

Merge branch 'master' into michaeljklein/pedantic-flag-tests

d62a5c7

move pedantic solving flag to execute.rs

7768e86

Merge branch 'master' into michaeljklein/pedantic-flag-tests

777d708

Merge branch 'master' into michaeljklein/pedantic-flag-tests

7481a46

Merge branch 'master' into michaeljklein/pedantic-flag-tests

0a6794d

Merge branch 'master' into michaeljklein/pedantic-flag-tests

743dafb

skip failing tests, update snapshots, use '--pedantic-solving' for ex…

656900b

…ternal repo checks

Merge branch 'master' into michaeljklein/pedantic-flag-tests

5ade20a

nargo fmt

e5ac54d

Merge branch 'master' into michaeljklein/pedantic-flag-tests

3374914

cargo insta

62adf29

Merge branch 'master' into michaeljklein/pedantic-flag-tests

82accbf

remove --pedantic-solving from rebuild.sh

543d8c4

michaeljklein marked this pull request as ready for review April 21, 2025 19:33

Merge branch 'master' into michaeljklein/pedantic-flag-tests

658343f

michaeljklein requested a review from a team April 21, 2025 19:33

asterite reviewed Apr 22, 2025

View reviewed changes

tooling/nargo_cli/tests/snapshots/execute__tests__strings_force_brillig_true_inliner_0.snap Outdated Show resolved Hide resolved

michaeljklein added 2 commits April 22, 2025 11:34

remove unused snapshot

324f79b

use method from 'master' to generate-solidity-verifiers.sh, but inclu…

5f07370

…de '--pedantic-solving'

asterite approved these changes Apr 22, 2025

View reviewed changes

TomAFrench enabled auto-merge April 22, 2025 15:44

Merge branch 'master' into michaeljklein/pedantic-flag-tests

83b2411

TomAFrench added this pull request to the merge queue Apr 22, 2025

Merged via the queue into master with commit 20fdf4c Apr 22, 2025
113 checks passed

TomAFrench deleted the michaeljklein/pedantic-flag-tests branch April 22, 2025 16:30

This was referenced Apr 23, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#13755

Closed

chore: Bump Noir reference AztecProtocol/aztec-packages#13781

Merged

AztecBot mentioned this pull request Apr 28, 2025

chore(master): release 0.87.0 AztecProtocol/aztec-packages#13800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enable '--pedantic-solving' on more tests#7701

chore: enable '--pedantic-solving' on more tests#7701
TomAFrench merged 24 commits intomasterfrom
michaeljklein/pedantic-flag-tests

michaeljklein commented Mar 13, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

michaeljklein commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

michaeljklein commented Mar 13, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading