feat(SSA): simplify array_get from param

[asterite]

Description

Problem

Resolves #10297

Summary

This is similar to what was done in #10295 except that it's only applied for array params where the index is in bounds.

Additional Context

I rewrote try_optimize_array_get_from_previous_set in a different way because:

• the optimization was only applied if the index was a known constant that fit in u32... which should always be true anyway
• the optimization would break the for loop when a MakeArray was found, cloning the array elements into elements, and then only performing the optimization if elements was Some. Instead, we can perform that logic right away, which removes this indirection but also the clone.

Documentation

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Changes to circuit sizes

Generated at commit: 969c5d0f79882f0bed256737377c6ec63995fe17, compared to commit: b43153bd34f52ea835f6b7715bcf2c1f931a0fc8

🧾 Summary (10% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
array_if_cond_simple	-8 ✅	-20.00%	-213 ✅	-6.95%
regression_9329	-17 ✅	-45.95%	-14 ✅	-10.53%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
conditional_1	2,618 (-12)	-0.46%	17,416 (0)	0.00%
regression_5252	23,283 (-1,008)	-4.15%	72,270 (-3,810)	-5.01%
array_if_cond_simple	32 (-8)	-20.00%	2,851 (-213)	-6.95%
regression_9329	20 (-17)	-45.95%	119 (-14)	-10.53%

[github-actions]

Changes to number of Brillig opcodes executed

Generated at commit: 969c5d0f79882f0bed256737377c6ec63995fe17, compared to commit: b43153bd34f52ea835f6b7715bcf2c1f931a0fc8

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
brillig_arrays_inliner_max	-57 ✅	-41.30%
brillig_arrays_inliner_zero	-57 ✅	-41.30%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
brillig_arrays_inliner_min	109 (-57)	-34.34%
brillig_arrays_inliner_max	81 (-57)	-41.30%
brillig_arrays_inliner_zero	81 (-57)	-41.30%

[github-actions]

Changes to Brillig bytecode sizes

Generated at commit: 969c5d0f79882f0bed256737377c6ec63995fe17, compared to commit: b43153bd34f52ea835f6b7715bcf2c1f931a0fc8

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
brillig_arrays_inliner_max	-40 ✅	-35.40%
brillig_arrays_inliner_zero	-40 ✅	-35.40%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
brillig_arrays_inliner_min	95 (-40)	-29.63%
brillig_arrays_inliner_max	73 (-40)	-35.40%
brillig_arrays_inliner_zero	73 (-40)	-35.40%

[asterite]

Cool, it seems the largest optimizations in #10295 came from this single change. Probably the other optimizations are good too but have less impact.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 6360b7d	Previous: b43153b	Ratio
test_report_zkpassport_noir-ecdsa_	3 s	2 s	1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 1157804	Previous: b43153b	Ratio
rollup-checkpoint-merge	0.004 s	0.003 s	1.33

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench