fix(mem2reg): Update array set value alias set and propagate array get result as alias

[vezenovm]

Description

Problem*

Alternative to #10175
Resolves #10070
Resolves #10020

Fix to timed out tests #10175 (review)

Summary*

We were appropriately setting the initial alias sets for the results of make_array, array_get, and array_set with arrays of references. We just were not also setting the alias sets of the array elements themselves to also include the result of array_get and array_set in their alias sets.

For example in this code:

        brillig(inline) fn main f0 {
          b0(v0: [&mut Field; 1], v1: u1):
            v3 = allocate -> &mut Field
            v4 = allocate -> &mut Field
            jmpif v1 then: b1, else: b2
          b1():
            v7 = array_set v0, index u32 0, value v3
            jmp b3(v7)
          b2():
            v6 = array_set v0, index u32 0, value v4
            jmp b3(v6)
          b3(v2: [&mut Field; 1]):
            v8 = array_get v2, index u32 0 -> &mut Field
            store Field 1 at v8
            store Field 2 at v3
            store Field 3 at v4
            v12 = load v8 -> Field
            return v12
        }

v6 and v7 have the appropriate alias sets. However, v3 and v4 were not being updated to include v6 and v7 in their own alias sets. This PR makes that change and #10070 passes.

Same thing for this case:

        acir(inline) predicate_pure fn main f0 {
          b0():
            v1 = allocate -> &mut Field
            store Field 0 at v1
            v3 = allocate -> &mut Field
            store Field 0 at v3
            v4 = make_array [v1, v3] : [&mut Field; 2]
            v5 = allocate -> &mut Field
            store Field 0 at v5
            jmp b1(u32 0)
          b1(v0: u32):
            v7 = eq v0, u32 0
            jmpif v7 then: b2, else: b3
          b2():
            v9 = array_get v4, index v0 -> &mut Field
            store Field 1 at v9
            store Field 2 at v1
            v12 = load v5 -> Field
            v13 = load v9 -> Field
            v14 = add v12, v13
            store v14 at v5
            v16 = unchecked_add v0, u32 1
            jmp b1(v16)
          b3():
            v8 = load v5 -> Field
            return v8
        }

v4 and v9 had the appropriate alias sets post the array_get in b2. However, the aliases of v4 (which are v1 and v3) were not being updated to include v9 in their alias sets. Once making this update #10020 passes.

Additional Context

We can see in #10242 (review) that the rollup-checkpoint-root-* tests are back.

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

ACVM Benchmarks

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
purely_sequential_opcodes	257113 ns/iter (± 529)	255650 ns/iter (± 1497)	1.01
perfectly_parallel_opcodes	228978 ns/iter (± 9135)	227403 ns/iter (± 3410)	1.01
perfectly_parallel_batch_inversion_opcodes	2796755 ns/iter (± 4461)	2792856 ns/iter (± 116926)	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Compilation Time

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
private-kernel-inner	1.724 s	1.704 s	1.01
private-kernel-reset	6.87 s	6.82 s	1.01
private-kernel-tail	1.454 s	1.344 s	1.08
rollup-block-root-first-empty-tx	1.416 s	1.47 s	0.96
rollup-block-root-single-tx	1.35 s	1.41 s	0.96
rollup-block-root	1.45 s	1.47 s	0.99
rollup-checkpoint-merge	1.412 s	1.496 s	0.94
rollup-checkpoint-root-single-block	201 s
rollup-checkpoint-root	196 s
rollup-root	1.496 s	1.638 s	0.91
rollup-tx-base-private	19.18 s	18.92 s	1.01
rollup-tx-base-public	78.1 s	76.98 s	1.01
rollup-tx-merge	1.456 s	1.374 s	1.06
semaphore-depth-10	0.799 s	0.799 s	1
sha512-100-bytes	1.624 s	2.235 s	0.73

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Opcode count

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
private-kernel-inner	14544 opcodes	14544 opcodes	1
private-kernel-reset	70415 opcodes	70415 opcodes	1
private-kernel-tail	11680 opcodes	11680 opcodes	1
rollup-block-root-first-empty-tx	1364 opcodes	1364 opcodes	1
rollup-block-root-single-tx	1048 opcodes	1048 opcodes	1
rollup-block-root	2409 opcodes	2409 opcodes	1
rollup-checkpoint-merge	2130 opcodes	2130 opcodes	1
rollup-checkpoint-root-single-block	962015 opcodes
rollup-checkpoint-root	963375 opcodes
rollup-root	2630 opcodes	2630 opcodes	1
rollup-tx-base-private	263908 opcodes	263908 opcodes	1
rollup-tx-base-public	245185 opcodes	245185 opcodes	1
rollup-tx-merge	1486 opcodes	1486 opcodes	1
semaphore-depth-10	5699 opcodes	5699 opcodes	1
sha512-100-bytes	13173 opcodes	13173 opcodes	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Test Suite Duration

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr	112 s	117 s	0.96
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts	139 s	133 s	1.05
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	356 s	285 s	1.25
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib	227 s	253 s	0.90
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types	126 s	134 s	0.94
test_report_noir-lang_noir-bignum_	152 s	205 s	0.74
test_report_noir-lang_noir_bigcurve_	326 s	423 s	0.77
test_report_noir-lang_sha256_	15 s	15 s	1
test_report_noir-lang_sha512_	13 s	15 s	0.87
test_report_zkpassport_noir-ecdsa_	2 s	1 s	2
test_report_zkpassport_noir_rsa_	1 s	1 s	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Time

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
private-kernel-inner	0.012 s	0.012 s	1
private-kernel-reset	0.153 s	0.153 s	1
private-kernel-tail	0.01 s	0.01 s	1
rollup-block-root-first-empty-tx	0.003 s	0.003 s	1
rollup-block-root-single-tx	0.003 s	0.003 s	1
rollup-block-root	0.006 s	0.004 s	1.50
rollup-checkpoint-merge	0.003 s	0.003 s	1
rollup-checkpoint-root-single-block	12.3 s
rollup-checkpoint-root	12.6 s
rollup-root	0.004 s	0.004 s	1
rollup-tx-base-private	0.304 s	0.303 s	1.00
rollup-tx-base-public	0.241 s	0.242 s	1.00
rollup-tx-merge	0.002 s	0.002 s	1
semaphore-depth-10	0.009 s	0.009 s	1
sha512-100-bytes	0.052 s	0.052 s	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	356 s	285 s	1.25
test_report_zkpassport_noir-ecdsa_	2 s	1 s	2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
rollup-block-root	0.006 s	0.004 s	1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

Artifact Size

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
private-kernel-inner	714.3 KB	714.3 KB	1
private-kernel-reset	1864 KB	1864 KB	1
private-kernel-tail	546.2 KB	546.2 KB	1
rollup-block-root-first-empty-tx	179.6 KB	179.6 KB	1
rollup-block-root-single-tx	177.9 KB	177.9 KB	1
rollup-block-root	257.9 KB	257.9 KB	1
rollup-checkpoint-merge	370.6 KB	370.6 KB	1
rollup-checkpoint-root-single-block	27640.2 KB
rollup-checkpoint-root	27685.9 KB
rollup-root	411.4 KB	411.4 KB	1
rollup-tx-base-private	4909.3 KB	4909.3 KB	1
rollup-tx-base-public	4555.4 KB	4555.4 KB	1
rollup-tx-merge	186.1 KB	186.1 KB	1
semaphore-depth-10	570.9 KB	570.9 KB	1
sha512-100-bytes	506.3 KB	506.3 KB	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Compilation Memory

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
private-kernel-inner	265.5 MB	265.5 MB	1
private-kernel-reset	493.18 MB	493.18 MB	1
private-kernel-tail	247.54 MB	247.54 MB	1
rollup-block-root-first-empty-tx	340.02 MB	340.02 MB	1
rollup-block-root-single-tx	337.41 MB	337.42 MB	1.00
rollup-block-root	340.43 MB	340.43 MB	1
rollup-checkpoint-merge	339.76 MB	339.76 MB	1
rollup-checkpoint-root-single-block	6810 MB	6810 MB	1
rollup-checkpoint-root	6810 MB
rollup-root	344.07 MB	344.07 MB	1
rollup-tx-base-private	1050 MB	1050 MB	1
rollup-tx-base-public	2890 MB	2890 MB	1
rollup-tx-merge	337.64 MB	337.64 MB	1
semaphore_depth_10	92.18 MB	92.18 MB	1
sha512_100_bytes	185.5 MB	185.48 MB	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Memory

Details

Benchmark suite	Current: ad52e5b	Previous: 6424d4a	Ratio
private-kernel-inner	253.63 MB	253.63 MB	1
private-kernel-reset	287.24 MB	287.24 MB	1
private-kernel-tail	243.5 MB	243.5 MB	1
rollup-block-root	337.87 MB	337.87 MB	1
rollup-checkpoint-merge	336.67 MB	336.67 MB	1
rollup-checkpoint-root-single-block	1020 MB
rollup-checkpoint-root	1020 MB
rollup-root	337.87 MB	337.87 MB	1
rollup-tx-base-private	451.42 MB	451.42 MB	1
rollup-tx-base-public	466.49 MB	466.49 MB	1
rollup-tx-merge	336.13 MB	336.13 MB	1
semaphore_depth_10	73.7 MB	73.7 MB	1
sha512_100_bytes	71.96 MB	71.96 MB	1

This comment was automatically generated by workflow using github-action-benchmark.

[jfecher]

Yeah, this looks a lot more like the common problem of "we need to update the alias set in both directions" now. I think this version of the fix is more likely to fix the core issue.