Skip to content

fix: do not simplify call-data values#10032

Merged
guipublic merged 24 commits intomasterfrom
gd/issue_9983
Nov 3, 2025
Merged

fix: do not simplify call-data values#10032
guipublic merged 24 commits intomasterfrom
gd/issue_9983

Conversation

@guipublic
Copy link
Contributor

Description

Problem*

Resolves #9984

Summary*

Input witness are not simplified in ACIR generation

Additional Context

The issue is about potential issues with Databus due to simplifications passes.
However, the databus values need to be updated during the various ssa passes because instructions may be transformed (e.g during unrolling) and mapped to equivalent instructions but with updated IDs.
It turns out that these transformations are correct within SSA passes because the databus ‘call-data’ is defined at the beginning of ssa generation. When a value is simplified, subsequent uses of the value will be replaced, but not its definition.
As a result, values in the call-data array may be updated, but not simplified.

On the other hand on ACIR side, the databus is initialized after ACIR generation, which creates witness for constant values and may replace call-data parameters with these constant witness.
We may want to do the same as with SSA, i.e generate the call-data array before ACIR generation, but this is not always possible, because call-data SSA values can be ‘array-get’ values which need to be properly resolved by ACIR generation.
Another possibility could be to generate the call-data array during ACIR generation but it would make the ACIR generation more inter-dependent to the databus.
I ended up with a simpler solution which avoid to simplify input witness with constant values. Indeed, call-data values are all inputs from main.
A small refinement could be to do this only for call-data parameters, but having this logic for all the inputs looks more coherent to me.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Changes to circuit sizes

Generated at commit: 1350dd6b8bfa83bfdae4d1dbb50acb4e8ad60746, compared to commit: 1324e732b92ee9624307ee226ffeed01610287a6

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
global_nested_array_call_arg_regression +4 ❌ +40.00% +2,747 ❌ +3309.64%
nested_array_call_arg_regression +4 ❌ +40.00% +2,747 ❌ +3309.64%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
global_nested_array_call_arg_regression 14 (+4) +40.00% 2,830 (+2,747) +3309.64%
nested_array_call_arg_regression 14 (+4) +40.00% 2,830 (+2,747) +3309.64%
slices 323 (0) 0.00% 3,936 (+1) +0.03%
conditional_1 2,653 (+35) +1.34% 17,416 (0) 0.00%

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 8b547ef Previous: 1324e73 Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@guipublic guipublic changed the title fix (9984): do not simplify call-data values fix: do not simplify call-data values Sep 30, 2025
@guipublic guipublic requested a review from a team September 30, 2025 11:39
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: df89010 Previous: 39f193c Ratio
perfectly_parallel_batch_inversion_opcodes 2779925 ns/iter (± 3766) 2254940 ns/iter (± 1115) 1.23

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 8b547ef Previous: 1324e73 Ratio
rollup-checkpoint-merge 0.004 s 0.003 s 1.33
sha512-100-bytes 0.065 s 0.048 s 1.35

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 3610282 Previous: 9808525 Ratio
sha512-100-bytes 1.903 s 1.572 s 1.21

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@guipublic guipublic added this pull request to the merge queue Nov 3, 2025
Merged via the queue into master with commit 9b08130 Nov 3, 2025
178 of 180 checks passed
@guipublic guipublic deleted the gd/issue_9983 branch November 3, 2025 10:14
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 5, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests (noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter (noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics` (noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of `FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function` (noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers (noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization` (noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests (noir-lang/noir#10319)
chore: bump external pinned commits (noir-lang/noir#10236)
fix: do not simplify call-data values (noir-lang/noir#10032)
chore: update directory name (noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error (noir-lang/noir#10313)
chore: green light for basic_conditional audit (noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis (noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`  (noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing  (noir-lang/noir#10327)
fix: remove leading stars from block doc comments (noir-lang/noir#10316)
fix: slice push_back when length is not known (noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs (noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs (noir-lang/noir#10318)
fix: "No size for slice" when using black_box (noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors (noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements (noir-lang/noir#10293)
chore: Document each elaborator trait function (noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests  (noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure (noir-lang/noir#10231)
feat(SSA): simplify array_get from param (noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation (noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes (noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and `VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file (noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX (noir-lang/noir#10287)
feat(github): Add Security Policy (noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var` (noir-lang/noir#10274)
chore(ACIR): document AcirValue (noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic (noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta data  (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files (noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in `noirc_evaluator/src/acir` (noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose (noir-lang/noir#10272)
feat(brillig): Automatic register deallocation (noir-lang/noir#10253)
chore: Add some detail to the trait documentation (noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs (noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted (noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module (noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler` (noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable" (noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments (noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing (noir-lang/noir#10250)
chore: greenlight Elaborator visibility (noir-lang/noir#10248)
chore(audit): Brillig VM nits (noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get result as alias  (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules (noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit tests  (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator (noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public` (noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests  (noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation (noir-lang/noir#10214)
chore: clone indexed call results (noir-lang/noir#10140)
chore(acvm): Optimize logic ops (noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR (noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays (noir-lang/noir#10198)
chore: redo typo PR by spuradage (noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg` (noir-lang/noir#9608)
chore: remove incremental mutation tests (noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc. (noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten` (noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers (noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass (noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls (noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR (noir-lang/noir#10201)
chore(ACIR): optimize slice_insert (noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes (noir-lang/noir#10120)
chore: address clippy warnings (noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...` (noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check` (noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads (noir-lang/noir#10100)
chore: add incremental mutation testing (noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow (noir-lang/noir#10173)
END_COMMIT_OVERRIDE

Co-authored-by: benesjan <janbenes1234@gmail.com>
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 5, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests
(noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the
inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter
(noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics`
(noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of
`FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function`
(noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers
(noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization`
(noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests
(noir-lang/noir#10319)
chore: bump external pinned commits
(noir-lang/noir#10236)
fix: do not simplify call-data values
(noir-lang/noir#10032)
chore: update directory name
(noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error
(noir-lang/noir#10313)
chore: green light for basic_conditional audit
(noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis
(noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`
(noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing
(noir-lang/noir#10327)
fix: remove leading stars from block doc comments
(noir-lang/noir#10316)
fix: slice push_back when length is not known
(noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs
(noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs
(noir-lang/noir#10318)
fix: "No size for slice" when using black_box
(noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors
(noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements
(noir-lang/noir#10293)
chore: Document each elaborator trait function
(noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests
(noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure
(noir-lang/noir#10231)
feat(SSA): simplify array_get from param
(noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation
(noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes
(noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and
`VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file
(noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX
(noir-lang/noir#10287)
feat(github): Add Security Policy
(noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var`
(noir-lang/noir#10274)
chore(ACIR): document AcirValue
(noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic
(noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta
data (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files
(noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in
`noirc_evaluator/src/acir`
(noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose
(noir-lang/noir#10272)
feat(brillig): Automatic register deallocation
(noir-lang/noir#10253)
chore: Add some detail to the trait documentation
(noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs
(noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted
(noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value
comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module
(noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler`
(noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable"
(noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments
(noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing
(noir-lang/noir#10250)
chore: greenlight Elaborator visibility
(noir-lang/noir#10248)
chore(audit): Brillig VM nits
(noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get
result as alias (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules
(noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit
tests (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator
(noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public`
(noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with
unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests
(noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation
(noir-lang/noir#10214)
chore: clone indexed call results
(noir-lang/noir#10140)
chore(acvm): Optimize logic ops
(noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR
(noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays
(noir-lang/noir#10198)
chore: redo typo PR by spuradage
(noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg`
(noir-lang/noir#9608)
chore: remove incremental mutation tests
(noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc.
(noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten`
(noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers
(noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass
(noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls
(noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR
(noir-lang/noir#10201)
chore(ACIR): optimize slice_insert
(noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes
(noir-lang/noir#10120)
chore: address clippy warnings
(noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to
constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...`
(noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check`
(noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads
(noir-lang/noir#10100)
chore: add incremental mutation testing
(noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow
(noir-lang/noir#10173)
END_COMMIT_OVERRIDE
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 5, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests
(noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the
inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter
(noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics`
(noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of
`FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function`
(noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers
(noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization`
(noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests
(noir-lang/noir#10319)
chore: bump external pinned commits
(noir-lang/noir#10236)
fix: do not simplify call-data values
(noir-lang/noir#10032)
chore: update directory name
(noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error
(noir-lang/noir#10313)
chore: green light for basic_conditional audit
(noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis
(noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`
(noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing
(noir-lang/noir#10327)
fix: remove leading stars from block doc comments
(noir-lang/noir#10316)
fix: slice push_back when length is not known
(noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs
(noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs
(noir-lang/noir#10318)
fix: "No size for slice" when using black_box
(noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors
(noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements
(noir-lang/noir#10293)
chore: Document each elaborator trait function
(noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests
(noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure
(noir-lang/noir#10231)
feat(SSA): simplify array_get from param
(noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation
(noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes
(noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and
`VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file
(noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX
(noir-lang/noir#10287)
feat(github): Add Security Policy
(noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var`
(noir-lang/noir#10274)
chore(ACIR): document AcirValue
(noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic
(noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta
data (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files
(noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in
`noirc_evaluator/src/acir`
(noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose
(noir-lang/noir#10272)
feat(brillig): Automatic register deallocation
(noir-lang/noir#10253)
chore: Add some detail to the trait documentation
(noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs
(noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted
(noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value
comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module
(noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler`
(noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable"
(noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments
(noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing
(noir-lang/noir#10250)
chore: greenlight Elaborator visibility
(noir-lang/noir#10248)
chore(audit): Brillig VM nits
(noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get
result as alias (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules
(noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit
tests (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator
(noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public`
(noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with
unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests
(noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation
(noir-lang/noir#10214)
chore: clone indexed call results
(noir-lang/noir#10140)
chore(acvm): Optimize logic ops
(noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR
(noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays
(noir-lang/noir#10198)
chore: redo typo PR by spuradage
(noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg`
(noir-lang/noir#9608)
chore: remove incremental mutation tests
(noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc.
(noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten`
(noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers
(noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass
(noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls
(noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR
(noir-lang/noir#10201)
chore(ACIR): optimize slice_insert
(noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes
(noir-lang/noir#10120)
chore: address clippy warnings
(noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to
constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...`
(noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check`
(noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads
(noir-lang/noir#10100)
chore: add incremental mutation testing
(noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow
(noir-lang/noir#10173)
END_COMMIT_OVERRIDE
charlielye pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 6, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests (noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter (noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics` (noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of `FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function` (noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers (noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization` (noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests (noir-lang/noir#10319)
chore: bump external pinned commits (noir-lang/noir#10236)
fix: do not simplify call-data values (noir-lang/noir#10032)
chore: update directory name (noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error (noir-lang/noir#10313)
chore: green light for basic_conditional audit (noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis (noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`  (noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing  (noir-lang/noir#10327)
fix: remove leading stars from block doc comments (noir-lang/noir#10316)
fix: slice push_back when length is not known (noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs (noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs (noir-lang/noir#10318)
fix: "No size for slice" when using black_box (noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors (noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements (noir-lang/noir#10293)
chore: Document each elaborator trait function (noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests  (noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure (noir-lang/noir#10231)
feat(SSA): simplify array_get from param (noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation (noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes (noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and `VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file (noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX (noir-lang/noir#10287)
feat(github): Add Security Policy (noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var` (noir-lang/noir#10274)
chore(ACIR): document AcirValue (noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic (noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta data  (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files (noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in `noirc_evaluator/src/acir` (noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose (noir-lang/noir#10272)
feat(brillig): Automatic register deallocation (noir-lang/noir#10253)
chore: Add some detail to the trait documentation (noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs (noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted (noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module (noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler` (noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable" (noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments (noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing (noir-lang/noir#10250)
chore: greenlight Elaborator visibility (noir-lang/noir#10248)
chore(audit): Brillig VM nits (noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get result as alias  (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules (noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit tests  (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator (noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public` (noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests  (noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation (noir-lang/noir#10214)
chore: clone indexed call results (noir-lang/noir#10140)
chore(acvm): Optimize logic ops (noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR (noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays (noir-lang/noir#10198)
chore: redo typo PR by spuradage (noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg` (noir-lang/noir#9608)
chore: remove incremental mutation tests (noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc. (noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten` (noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers (noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass (noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls (noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR (noir-lang/noir#10201)
chore(ACIR): optimize slice_insert (noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes (noir-lang/noir#10120)
chore: address clippy warnings (noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...` (noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check` (noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads (noir-lang/noir#10100)
chore: add incremental mutation testing (noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow (noir-lang/noir#10173)
END_COMMIT_OVERRIDE

Co-authored-by: benesjan <janbenes1234@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

constant_folding: potential bug when mapping data_bus

3 participants