Skip to content

fix: address off-by-one error when removing casts before constraining to constant#10194

Merged
TomAFrench merged 1 commit intomasterfrom
tf/fix-edge-case-in-constrain-decomposition
Oct 16, 2025
Merged

fix: address off-by-one error when removing casts before constraining to constant#10194
TomAFrench merged 1 commit intomasterfrom
tf/fix-edge-case-in-constrain-decomposition

Conversation

@TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Oct 15, 2025

…

Description

Problem*

Resolves

Summary*

This PR corrects an off-by-one error in simplify/constrain.rs. I've also added various other tests as necessary to get mutation testing passing.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title fix: remove casts to constrain a value to be equal to the maximum value of original type fix: address off-by-one error when removing casts before constraining to constant Oct 15, 2025
@TomAFrench TomAFrench requested a review from a team October 15, 2025 12:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Changes to Brillig bytecode sizes

Generated at commit: 38e24551dc78b6bda4e3cfc0c4a99681a69123e2, compared to commit: 3b0181a89c3ed0eacaf6646d569ae9f13dfdba39

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
cast_bool_inliner_max -3 ✅ -10.34%
cast_bool_inliner_min -3 ✅ -10.34%
cast_bool_inliner_zero -3 ✅ -10.34%
Full diff report 👇
Program Brillig opcodes (+/-) %
unsigned_to_signed_cast_inliner_max 48 (-1) -2.04%
unsigned_to_signed_cast_inliner_min 48 (-1) -2.04%
unsigned_to_signed_cast_inliner_zero 48 (-1) -2.04%
regression_8212_inliner_max 36 (-1) -2.70%
regression_8212_inliner_min 36 (-1) -2.70%
regression_8212_inliner_zero 36 (-1) -2.70%
cast_bool_inliner_max 26 (-3) -10.34%
cast_bool_inliner_min 26 (-3) -10.34%
cast_bool_inliner_zero 26 (-3) -10.34%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Changes to circuit sizes

Generated at commit: 38e24551dc78b6bda4e3cfc0c4a99681a69123e2, compared to commit: 3b0181a89c3ed0eacaf6646d569ae9f13dfdba39

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
cast_bool -4 ✅ -80.00% -3 ✅ -5.17%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
cast_bool 1 (-4) -80.00% 55 (-3) -5.17%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Changes to number of Brillig opcodes executed

Generated at commit: 38e24551dc78b6bda4e3cfc0c4a99681a69123e2, compared to commit: 3b0181a89c3ed0eacaf6646d569ae9f13dfdba39

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
cast_bool_inliner_max -3 ✅ -12.00%
cast_bool_inliner_min -3 ✅ -12.00%
cast_bool_inliner_zero -3 ✅ -12.00%
Full diff report 👇
Program Brillig opcodes (+/-) %
unsigned_to_signed_cast_inliner_max 38 (-1) -2.56%
unsigned_to_signed_cast_inliner_min 38 (-1) -2.56%
unsigned_to_signed_cast_inliner_zero 38 (-1) -2.56%
regression_8212_inliner_max 32 (-1) -3.03%
regression_8212_inliner_min 32 (-1) -3.03%
regression_8212_inliner_zero 32 (-1) -3.03%
cast_bool_inliner_max 22 (-3) -12.00%
cast_bool_inliner_min 22 (-3) -12.00%
cast_bool_inliner_zero 22 (-3) -12.00%

github-actions[bot]
github-actions bot reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 09ef981 Previous: 3b0181a Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

asterite
asterite approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@asterite asterite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Reviewing this file left me with some questions:

  1. Why when original_typ_max_value is Ok(false), meaning the constrain will always fail, isn't replaced with an always-failing constrain?
  2. I see or is optimized but and isn't and maybe it could be (we need to constrain both values to 1) -> ah, maybe nevermind, I guess this only applies to bool it seems this is already happening, because bool and is turned into a multiplication

@TomAFrench
Copy link
Member Author

TomAFrench commented Oct 16, 2025

Why when original_typ_max_value is Ok(false), meaning the constrain will always fail, isn't replaced with an always-failing constrain?

🤷 This was written before we started pushing to replace known failing constraints with constrain 1 == 0

@TomAFrench TomAFrench added this pull request to the merge queue Oct 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
@TomAFrench TomAFrench added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit 64d5926 Oct 16, 2025
133 checks passed
@TomAFrench TomAFrench deleted the tf/fix-edge-case-in-constrain-decomposition branch October 16, 2025 11:58
@noirwhal noirwhal mentioned this pull request Oct 15, 2025
Merged
@AztecBot AztecBot mentioned this pull request Oct 17, 2025
Merged
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 5, 2025
@AztecBot @benesjan
chore: Bump Noir reference
1390793 
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests (noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter (noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics` (noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of `FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function` (noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers (noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization` (noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests (noir-lang/noir#10319)
chore: bump external pinned commits (noir-lang/noir#10236)
fix: do not simplify call-data values (noir-lang/noir#10032)
chore: update directory name (noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error (noir-lang/noir#10313)
chore: green light for basic_conditional audit (noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis (noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`  (noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing  (noir-lang/noir#10327)
fix: remove leading stars from block doc comments (noir-lang/noir#10316)
fix: slice push_back when length is not known (noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs (noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs (noir-lang/noir#10318)
fix: "No size for slice" when using black_box (noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors (noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements (noir-lang/noir#10293)
chore: Document each elaborator trait function (noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests  (noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure (noir-lang/noir#10231)
feat(SSA): simplify array_get from param (noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation (noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes (noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and `VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file (noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX (noir-lang/noir#10287)
feat(github): Add Security Policy (noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var` (noir-lang/noir#10274)
chore(ACIR): document AcirValue (noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic (noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta data  (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files (noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in `noirc_evaluator/src/acir` (noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose (noir-lang/noir#10272)
feat(brillig): Automatic register deallocation (noir-lang/noir#10253)
chore: Add some detail to the trait documentation (noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs (noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted (noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module (noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler` (noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable" (noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments (noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing (noir-lang/noir#10250)
chore: greenlight Elaborator visibility (noir-lang/noir#10248)
chore(audit): Brillig VM nits (noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get result as alias  (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules (noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit tests  (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator (noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public` (noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests  (noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation (noir-lang/noir#10214)
chore: clone indexed call results (noir-lang/noir#10140)
chore(acvm): Optimize logic ops (noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR (noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays (noir-lang/noir#10198)
chore: redo typo PR by spuradage (noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg` (noir-lang/noir#9608)
chore: remove incremental mutation tests (noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc. (noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten` (noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers (noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass (noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls (noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR (noir-lang/noir#10201)
chore(ACIR): optimize slice_insert (noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes (noir-lang/noir#10120)
chore: address clippy warnings (noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...` (noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check` (noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads (noir-lang/noir#10100)
chore: add incremental mutation testing (noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow (noir-lang/noir#10173)
END_COMMIT_OVERRIDE

Co-authored-by: benesjan <janbenes1234@gmail.com>
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 5, 2025
@benesjan
chore: Bump Noir reference (#17745)
76c5d7d 
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests
(noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the
inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter
(noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics`
(noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of
`FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function`
(noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers
(noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization`
(noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests
(noir-lang/noir#10319)
chore: bump external pinned commits
(noir-lang/noir#10236)
fix: do not simplify call-data values
(noir-lang/noir#10032)
chore: update directory name
(noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error
(noir-lang/noir#10313)
chore: green light for basic_conditional audit
(noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis
(noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`
(noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing
(noir-lang/noir#10327)
fix: remove leading stars from block doc comments
(noir-lang/noir#10316)
fix: slice push_back when length is not known
(noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs
(noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs
(noir-lang/noir#10318)
fix: "No size for slice" when using black_box
(noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors
(noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements
(noir-lang/noir#10293)
chore: Document each elaborator trait function
(noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests
(noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure
(noir-lang/noir#10231)
feat(SSA): simplify array_get from param
(noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation
(noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes
(noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and
`VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file
(noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX
(noir-lang/noir#10287)
feat(github): Add Security Policy
(noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var`
(noir-lang/noir#10274)
chore(ACIR): document AcirValue
(noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic
(noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta
data (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files
(noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in
`noirc_evaluator/src/acir`
(noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose
(noir-lang/noir#10272)
feat(brillig): Automatic register deallocation
(noir-lang/noir#10253)
chore: Add some detail to the trait documentation
(noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs
(noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted
(noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value
comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module
(noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler`
(noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable"
(noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments
(noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing
(noir-lang/noir#10250)
chore: greenlight Elaborator visibility
(noir-lang/noir#10248)
chore(audit): Brillig VM nits
(noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get
result as alias (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules
(noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit
tests (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator
(noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public`
(noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with
unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests
(noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation
(noir-lang/noir#10214)
chore: clone indexed call results
(noir-lang/noir#10140)
chore(acvm): Optimize logic ops
(noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR
(noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays
(noir-lang/noir#10198)
chore: redo typo PR by spuradage
(noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg`
(noir-lang/noir#9608)
chore: remove incremental mutation tests
(noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc.
(noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten`
(noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers
(noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass
(noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls
(noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR
(noir-lang/noir#10201)
chore(ACIR): optimize slice_insert
(noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes
(noir-lang/noir#10120)
chore: address clippy warnings
(noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to
constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...`
(noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check`
(noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads
(noir-lang/noir#10100)
chore: add incremental mutation testing
(noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow
(noir-lang/noir#10173)
END_COMMIT_OVERRIDE
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 5, 2025
@benesjan
chore: Bump Noir reference (#17745)
b95e36c 
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests
(noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the
inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter
(noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics`
(noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of
`FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function`
(noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers
(noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization`
(noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests
(noir-lang/noir#10319)
chore: bump external pinned commits
(noir-lang/noir#10236)
fix: do not simplify call-data values
(noir-lang/noir#10032)
chore: update directory name
(noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error
(noir-lang/noir#10313)
chore: green light for basic_conditional audit
(noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis
(noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`
(noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing
(noir-lang/noir#10327)
fix: remove leading stars from block doc comments
(noir-lang/noir#10316)
fix: slice push_back when length is not known
(noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs
(noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs
(noir-lang/noir#10318)
fix: "No size for slice" when using black_box
(noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors
(noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements
(noir-lang/noir#10293)
chore: Document each elaborator trait function
(noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests
(noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure
(noir-lang/noir#10231)
feat(SSA): simplify array_get from param
(noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation
(noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes
(noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and
`VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file
(noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX
(noir-lang/noir#10287)
feat(github): Add Security Policy
(noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var`
(noir-lang/noir#10274)
chore(ACIR): document AcirValue
(noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic
(noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta
data (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files
(noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in
`noirc_evaluator/src/acir`
(noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose
(noir-lang/noir#10272)
feat(brillig): Automatic register deallocation
(noir-lang/noir#10253)
chore: Add some detail to the trait documentation
(noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs
(noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted
(noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value
comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module
(noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler`
(noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable"
(noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments
(noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing
(noir-lang/noir#10250)
chore: greenlight Elaborator visibility
(noir-lang/noir#10248)
chore(audit): Brillig VM nits
(noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get
result as alias (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules
(noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit
tests (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator
(noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public`
(noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with
unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests
(noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation
(noir-lang/noir#10214)
chore: clone indexed call results
(noir-lang/noir#10140)
chore(acvm): Optimize logic ops
(noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR
(noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays
(noir-lang/noir#10198)
chore: redo typo PR by spuradage
(noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg`
(noir-lang/noir#9608)
chore: remove incremental mutation tests
(noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc.
(noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten`
(noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers
(noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass
(noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls
(noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR
(noir-lang/noir#10201)
chore(ACIR): optimize slice_insert
(noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes
(noir-lang/noir#10120)
chore: address clippy warnings
(noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to
constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...`
(noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check`
(noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads
(noir-lang/noir#10100)
chore: add incremental mutation testing
(noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow
(noir-lang/noir#10173)
END_COMMIT_OVERRIDE
charlielye pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 6, 2025
@AztecBot @benesjan @charlielye
chore: Bump Noir reference
49d3943 
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(frontend): Elaborator assignment unit tests (noir-lang/noir#10362)
fix(elaborator): Keep the status of the outer `unsafe` block if the inner is unnecessary (noir-lang/noir#10361)
chore: Start greenlight of interpreter (noir-lang/noir#10354)
chore: bump bb (noir-lang/noir#10359)
feat: `TypeDefinition::as_type_with_generics` (noir-lang/noir#10315)
fix(elaborator): Create new type variable for each generic kind of `FmtStr` (noir-lang/noir#10349)
chore: require ≥2 `FunctionId`'s in `create_apply_function` (noir-lang/noir#10329)
chore(test): Show that `#[oracle]` can take and return function pointers (noir-lang/noir#10178)
fix: check value of `ArraySet` during `array_set_optimization` (noir-lang/noir#10325)
chore(frontend): Comptime item generation unit tests (noir-lang/noir#10319)
chore: bump external pinned commits (noir-lang/noir#10236)
fix: do not simplify call-data values (noir-lang/noir#10032)
chore: update directory name (noir-lang/noir#10348)
feat: Add `#[must_use]` attribute to promote unused warning to an error (noir-lang/noir#10313)
chore: green light for basic_conditional audit (noir-lang/noir#10134)
chore: add unit tests to show some features of the analysis (noir-lang/noir#10286)
fix(print): Convert `HirType::Function` into `PrintableType::Tuple`  (noir-lang/noir#10189)
chore(frontend): Quoting/unquoting roundtrip testing  (noir-lang/noir#10327)
fix: remove leading stars from block doc comments (noir-lang/noir#10316)
fix: slice push_back when length is not known (noir-lang/noir#10206)
chore: Fix typo in defunctionalize docs (noir-lang/noir#10321)
chore(frontend): Elaborator comptime module docs (noir-lang/noir#10318)
fix: "No size for slice" when using black_box (noir-lang/noir#10312)
chore(audit): Fix vector items offset and other refactors (noir-lang/noir#10294)
chore(audit): Refactors and tests for reg-to-reg movements (noir-lang/noir#10293)
chore: Document each elaborator trait function (noir-lang/noir#10303)
chore(frontend): Elaborator impls documentation and additional tests  (noir-lang/noir#10302)
feat(ACIR): reuse element_type_sizes blocks with the same structure (noir-lang/noir#10231)
feat(SSA): simplify array_get from param (noir-lang/noir#10300)
chore(frontend): Elaborator lazy globals and documentation (noir-lang/noir#10260)
chore: avoid unrolling loop headers twice in unrolling passes (noir-lang/noir#10284)
chore(audit): Refactors in `BrilligGlobals`, `ConstantAllocation` and `VariableLiveness` (noir-lang/noir#10265)
chore: Move variable elaboration to its own file (noir-lang/noir#10285)
chore(ACIR): use u32::MAX for PLACEHOLDER_BRILLIG_INDEX (noir-lang/noir#10287)
feat(github): Add Security Policy (noir-lang/noir#10262)
chore(ACIR): handle TODO in `more_than_eq_var` (noir-lang/noir#10274)
chore(ACIR): document AcirValue (noir-lang/noir#10276)
chore(Brillig): no need to handle ArrayLen intrinsic (noir-lang/noir#10280)
chore(frontend): Split out trait impl setup when defining function meta data  (noir-lang/noir#10271)
feat(LSP): show errors on stdlib files (noir-lang/noir#10283)
chore: typos and some refactors, tests, etc in `noirc_evaluator/src/acir` (noir-lang/noir#10255)
chore(ACIR): handle TODO in radix_decompose (noir-lang/noir#10272)
feat(brillig): Automatic register deallocation (noir-lang/noir#10253)
chore: Add some detail to the trait documentation (noir-lang/noir#10273)
chore(frontend): Elaborator struct collection docs (noir-lang/noir#10266)
chore(ACIR): add a test for OpcodeResolutionError::AcirMainCallAttempted (noir-lang/noir#10254)
fix(ssa-interpreter): Add integer modulus to unfit `Field` if the value comes from a subtraction (noir-lang/noir#10241)
chore(frontend): Elaborator function module (noir-lang/noir#10252)
chore: typos and some refactors, tests, etc in `acvm/src/compiler` (noir-lang/noir#10111)
chore(ACIR): turn "todo" into "unreachable" (noir-lang/noir#10251)
chore(frontend): Elaborator module doc comments (noir-lang/noir#10249)
chore(ACIR): more Circuit, Expression and Opcode parsing (noir-lang/noir#10250)
chore: greenlight Elaborator visibility (noir-lang/noir#10248)
chore(audit): Brillig VM nits (noir-lang/noir#10237)
fix(mem2reg): Update array set value alias set and propagate array get result as alias  (noir-lang/noir#10242)
chore(frontend): Split up traits tests module into submodules (noir-lang/noir#10229)
chore(frontend): HIR printer module for inline macro expansion unit tests  (noir-lang/noir#10232)
chore(frontend): Modularize the Elaborator (noir-lang/noir#10202)
chore: Improve compilation time on `rollup-tx-base-public` (noir-lang/noir#10224)
fix(mem2reg): Updating referenced value invalidate addresses with unknown aliases (noir-lang/noir#10175)
chore(frontend): Re-organize frontend tests  (noir-lang/noir#10221)
chore(ACIR): simpler AsSlice implementation (noir-lang/noir#10214)
chore: clone indexed call results (noir-lang/noir#10140)
chore(acvm): Optimize logic ops (noir-lang/noir#10222)
chore: simplify `x > 0` to `x != 0` for unsigned types in ACIR (noir-lang/noir#10220)
fix(ACIR): correct brillig parameter slice length for dynamic arrays (noir-lang/noir#10198)
chore: redo typo PR by spuradage (noir-lang/noir#10226)
feat: attempt to inline successors in `simplify_cfg` (noir-lang/noir#9608)
chore: remove incremental mutation tests (noir-lang/noir#10212)
chore(ACIR): display/parse memory arrays as b0, b1, etc. (noir-lang/noir#10211)
chore(ACIR): no need to return types in `flatten` (noir-lang/noir#10210)
chore(ACIR): make it clear that modulo is only for signed integers (noir-lang/noir#10209)
chore: document precondition to unrolling SSA pass (noir-lang/noir#10208)
chore(ACIR): better display/parse for blackbox calls (noir-lang/noir#10157)
chore: assume Intrinsic::ArrayLen never reaches ACIR (noir-lang/noir#10201)
chore(ACIR): optimize slice_insert (noir-lang/noir#10164)
chore: add minimal reproductions for Cantina issues + typo fixes (noir-lang/noir#10120)
chore: address clippy warnings (noir-lang/noir#10207)
fix: address off-by-one error when removing casts before constraining to constant (noir-lang/noir#10194)
chore(ACIR): prefer displaying `ASSERT return_value = ...` (noir-lang/noir#10195)
chore: remove if-condition from `array_set_optimization_pre_check` (noir-lang/noir#10193)
chore(ssa_fuzzer): allow brillig fuzz target to work in multi threads (noir-lang/noir#10100)
chore: add incremental mutation testing (noir-lang/noir#10196)
chore: ensure that `useful_instructions` cannot overflow (noir-lang/noir#10173)
END_COMMIT_OVERRIDE

Co-authored-by: benesjan <janbenes1234@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@asterite asterite asterite approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomAFrench @asterite