chore(audit): Refactors and tests for reg-to-reg movements

[aakoshh]

Description

Problem*

The correctness of the register-to-register movements that copy return values was a bit hard to see at first glance.

Summary*

• Resets next_section to 1 every time a new context is entered, which sets section to 0.
• Renames BrilligBlock::compile to BrilligBlock::compile_block, to make it easier to remember, being next to compile_globals.
• Changes BrilligBlock::initialize_constants to take a Location rather than a list of constants, so it doesn't have to assume that its inputs are really constants, it can just look up the list in ConstantAllocation.
• Contains refactoring and extra property based tests for the codegen_mov_registers_to_registers machinery.
• Changes codegen_return to take BrilligVariable instead of MemoryAddress, like the other codegen functions in its vicinity do.
• Changes LoopDetector to only return the blocks which are in the loop; this wouldn't come up if we go through codegen_mov_registers_to_registers because it would cause a panic, but if we called it from somewhere else in the future, it might be surprising.

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	tsc-multi@​1.1.0
	pako@​1.0.11
	glob@​10.4.5
	copy-webpack-plugin@​11.0.0
	globals@​14.0.0
	cspell@​8.19.4
	memfs@​3.5.3

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		form-data@4.0.0 has a Critical CVE. CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL) Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4 Patched version: 4.0.4 From: ? → npm/form-data@4.0.0 ℹ Read more on: This package | This alert | What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/form-data@4.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		lunr-languages@1.14.0 has Obfuscated code. Confidence: 0.91 Location: Package overview From: ? → npm/lunr-languages@1.14.0 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/lunr-languages@1.14.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		registry-auth-token@3.3.2 has Obfuscated code. Confidence: 0.94 Location: Package overview From: ? → npm/registry-auth-token@3.3.2 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/registry-auth-token@3.3.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: c7d18c2	Previous: 6826de8	Ratio
rollup-checkpoint-merge	0.004 s	0.003 s	1.33
sha512-100-bytes	0.08 s	0.051 s	1.57

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 238d2de	Previous: 6826de8	Ratio
perfectly_parallel_batch_inversion_opcodes	2793221 ns/iter (± 2227)	2259734 ns/iter (± 10347)	1.24

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 238d2de	Previous: 6826de8	Ratio
test_report_zkpassport_noir_rsa_	1 s	0 s	+∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[vezenovm]

Looks good. I have not yet reviewed #10305 fully but just noting that it looks like we will have some conflicts. We probably should chose between that new approach and these refactors as to not cause extra work.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 83c0e45	Previous: 6826de8	Ratio
rollup-tx-base-private	24.02 s	17.74 s	1.35

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench