chore(acvm): Optimize logic ops

[vezenovm]

Description

Problem*

No issue just something I noticed so decided to do a quick experiment.

I noticed we were reversing our byte array two times in mask_vector_le which came off as totally unnecessary. Also, in FieldElement::to_be_bytes we already compute the LE order then reverse the array to get the big endian bytes. So we were doing a lot of unnecessary reversals.

Summary*

I switched mask_to_le_bytes to fetch the LE representation of the field and simplified mask_vector_le so that it no longer reversed the byte array multiple times.

I added some benchmarks which essentially copied those from under acvm-repo/bn254_blackbox_solver/benches/criterion.rs.

These are the best results I got on master:

test logic_ops/bit_and_8bits ... bench:         428 ns/iter (+/- 15)
test logic_ops/bit_xor_8bits ... bench:         428 ns/iter (+/- 51)
test logic_ops/bit_and_32bits ... bench:         454 ns/iter (+/- 1)
test logic_ops/bit_xor_32bits ... bench:         448 ns/iter (+/- 1)
test logic_ops/bit_and_64bits ... bench:         450 ns/iter (+/- 4)
test logic_ops/bit_xor_64bits ... bench:         445 ns/iter (+/- 3)

On this branch:

test logic_ops/bit_and_8bits ... bench:         346 ns/iter (+/- 2)
test logic_ops/bit_xor_8bits ... bench:         350 ns/iter (+/- 4)
test logic_ops/bit_and_32bits ... bench:         379 ns/iter (+/- 2)
test logic_ops/bit_xor_32bits ... bench:         369 ns/iter (+/- 17)
test logic_ops/bit_and_64bits ... bench:         379 ns/iter (+/- 3)
test logic_ops/bit_xor_64bits ... bench:         367 ns/iter (+/- 2)

I don't expect this to have an effect on most programs but we still see ~15-20% improvement in the benchmarks above.

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

ACVM Benchmarks

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
purely_sequential_opcodes	261926 ns/iter (± 945)	268193 ns/iter (± 654)	0.98
perfectly_parallel_opcodes	232075 ns/iter (± 2819)	231993 ns/iter (± 2903)	1.00
perfectly_parallel_batch_inversion_opcodes	2797916 ns/iter (± 2412)	2785310 ns/iter (± 1354)	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​web/​dev-server-import-maps@​0.2.1
	@​web/​test-runner-playwright@​0.11.1
	@​web/​dev-server-esbuild@​1.0.4
	buffer-esm@​1.2.0
	toml@​3.0.0
	@​ltd/​j-toml@​1.38.0
	@​nomicfoundation/​hardhat-chai-matchers@​2.1.0
	smol-toml@​1.4.2
	@​esm-bundle/​chai@​4.3.4
	ethers@​6.15.0
	@​web/​test-runner@​0.20.2
	tslog@​4.10.2
	hardhat@​2.26.3
	@​nomicfoundation/​hardhat-ethers@​3.1.0
	@​aztec/​bb.js@​3.0.0-nightly.20251014

View full report

[github-actions]

Test Suite Duration

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr	119 s	119 s	1
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts	127 s	128 s	0.99
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	259 s	293 s	0.88
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib	233 s	237 s	0.98
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types	152 s	151 s	1.01
test_report_noir-lang_noir-bignum_	163 s	165 s	0.99
test_report_noir-lang_noir_bigcurve_	356 s	326 s	1.09
test_report_noir-lang_sha256_	15 s	17 s	0.88
test_report_noir-lang_sha512_	14 s	13 s	1.08
test_report_zkpassport_noir-ecdsa_	3 s	3 s	1
test_report_zkpassport_noir_rsa_	1 s	1 s	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Opcode count

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
private-kernel-inner	14544 opcodes	14544 opcodes	1
private-kernel-reset	70418 opcodes	70418 opcodes	1
private-kernel-tail	11680 opcodes	11680 opcodes	1
rollup-block-root-first-empty-tx	1365 opcodes	1365 opcodes	1
rollup-block-root-single-tx	1049 opcodes	1049 opcodes	1
rollup-block-root	2410 opcodes	2410 opcodes	1
rollup-checkpoint-merge	2130 opcodes	2130 opcodes	1
rollup-checkpoint-root-single-block	962022 opcodes	962022 opcodes	1
rollup-checkpoint-root	963382 opcodes	963382 opcodes	1
rollup-root	2630 opcodes	2630 opcodes	1
rollup-tx-base-private	263910 opcodes	263910 opcodes	1
rollup-tx-base-public	245187 opcodes	245187 opcodes	1
rollup-tx-merge	1486 opcodes	1486 opcodes	1
semaphore-depth-10	5700 opcodes	5700 opcodes	1
sha512-100-bytes	13173 opcodes	13173 opcodes	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Time

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
private-kernel-inner	0.012 s	0.012 s	1
private-kernel-reset	0.152 s	0.153 s	0.99
private-kernel-tail	0.01 s	0.01 s	1
rollup-block-root-first-empty-tx	0.003 s	0.003 s	1
rollup-block-root-single-tx	0.002 s	0.003 s	0.67
rollup-block-root	0.004 s	0.004 s	1
rollup-checkpoint-merge	0.003 s	0.004 s	0.75
rollup-checkpoint-root-single-block	12.5 s	12.7 s	0.98
rollup-checkpoint-root	12.1 s	12.4 s	0.98
rollup-root	0.004 s	0.005 s	0.80
rollup-tx-base-private	0.305 s	0.339 s	0.90
rollup-tx-base-public	0.241 s	0.238 s	1.01
rollup-tx-merge	0.002 s	0.002 s	1
semaphore-depth-10	0.009 s	0.009 s	1
sha512-100-bytes	0.059 s	0.053 s	1.11

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Compilation Time

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
private-kernel-inner	1.69 s	1.728 s	0.98
private-kernel-reset	6.736 s	6.824 s	0.99
private-kernel-tail	1.322 s	1.392 s	0.95
rollup-block-root-first-empty-tx	1.382 s	1.492 s	0.93
rollup-block-root-single-tx	1.48 s	1.36 s	1.09
rollup-block-root	1.52 s	1.41 s	1.08
rollup-checkpoint-merge	1.46 s	1.414 s	1.03
rollup-checkpoint-root-single-block	212 s	220 s	0.96
rollup-checkpoint-root	209 s	212 s	0.99
rollup-root	1.476 s	1.518 s	0.97
rollup-tx-base-private	19.38 s	24.42 s	0.79
rollup-tx-base-public	138.8 s	132.8 s	1.05
rollup-tx-merge	1.348 s	1.422 s	0.95
semaphore-depth-10	0.782 s	0.797 s	0.98
sha512-100-bytes	1.542 s	1.531 s	1.01

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: b428c7c	Previous: 8d78787	Ratio
rollup-block-root-single-tx	2 s	1.36 s	1.47

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

Compilation Memory

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
private-kernel-inner	265.5 MB	265.5 MB	1
private-kernel-reset	493.18 MB	493.18 MB	1
private-kernel-tail	247.54 MB	247.54 MB	1
rollup-block-root-first-empty-tx	339.97 MB	339.97 MB	1
rollup-block-root-single-tx	337.41 MB	337.41 MB	1
rollup-block-root	340.44 MB	340.44 MB	1
rollup-checkpoint-merge	339.76 MB	339.76 MB	1
rollup-checkpoint-root-single-block	6810 MB	6810 MB	1
rollup-checkpoint-root	6810 MB	6810 MB	1
rollup-root	344.07 MB	344.07 MB	1
rollup-tx-base-private	1050 MB	1050 MB	1
rollup-tx-base-public	2890 MB	2890 MB	1
rollup-tx-merge	337.64 MB	337.64 MB	1
semaphore_depth_10	92.18 MB	92.18 MB	1
sha512_100_bytes	185.46 MB	185.55 MB	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Artifact Size

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
private-kernel-inner	714.3 KB	714.3 KB	1
private-kernel-reset	1864.5 KB	1864.5 KB	1
private-kernel-tail	546.2 KB	546.2 KB	1
rollup-block-root-first-empty-tx	179.8 KB	179.8 KB	1
rollup-block-root-single-tx	178.1 KB	178.1 KB	1
rollup-block-root	258.1 KB	258.1 KB	1
rollup-checkpoint-merge	370.6 KB	370.6 KB	1
rollup-checkpoint-root-single-block	27640.9 KB	27640.9 KB	1
rollup-checkpoint-root	27686.8 KB	27686.8 KB	1
rollup-root	411.4 KB	411.4 KB	1
rollup-tx-base-private	4906.9 KB	4906.9 KB	1
rollup-tx-base-public	4555.1 KB	4555.1 KB	1
rollup-tx-merge	186.1 KB	186.1 KB	1
semaphore-depth-10	570.7 KB	570.7 KB	1
sha512-100-bytes	506.3 KB	506.3 KB	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Memory

Details

Benchmark suite	Current: 5b2597b	Previous: 8d78787	Ratio
private-kernel-inner	253.63 MB	253.63 MB	1
private-kernel-reset	287.24 MB	287.24 MB	1
private-kernel-tail	243.5 MB	243.5 MB	1
rollup-block-root	337.87 MB	337.87 MB	1
rollup-checkpoint-merge	336.67 MB	336.67 MB	1
rollup-checkpoint-root-single-block	1020 MB	1020 MB	1
rollup-checkpoint-root	1020 MB	1020 MB	1
rollup-root	337.87 MB	337.87 MB	1
rollup-tx-base-private	451.42 MB	451.42 MB	1
rollup-tx-base-public	466.49 MB	466.49 MB	1
rollup-tx-merge	336.13 MB	336.13 MB	1
semaphore_depth_10	73.69 MB	73.69 MB	1
sha512_100_bytes	71.96 MB	71.96 MB	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: d6b34af	Previous: 8d78787	Ratio
sha512-100-bytes	0.065 s	0.053 s	1.23

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench