NRG: When clfs=0, don't snapshot very often#6277
Merged
derekcollison merged 1 commit intomainfrom Dec 18, 2024
Merged
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the stream is ingesting loads of new messages, for example in a benchmark, either the
compactNumMinorcompactSizeMinwould be reached fairly quickly. TheminSnapDelta(10s) is used to not snapshot too often, since that would degrade performance.However, if
clfs=0then we'd be forcing snapshots every time the compact minimums are reached.Signed-off-by: Maurice van Veen github@mauricevanveen.com