Strip unnecessary ClientInfo fields from stream & consumer assignment proposals#6326
Merged
derekcollison merged 1 commit intomainfrom Jan 6, 2025
Merged
Strip unnecessary ClientInfo fields from stream & consumer assignment proposals#6326derekcollison merged 1 commit intomainfrom
ClientInfo fields from stream & consumer assignment proposals#6326derekcollison merged 1 commit intomainfrom
Conversation
derekcollison
requested changes
Jan 6, 2025
…nt proposals Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/clientinfos
branch
from
10fb8f4 to
2183448
Compare
neilalexander
force-pushed
the
neil/clientinfos
branch
from
2183448 to
c79d802
Compare
Member
Author
|
For now I've pulled the pooling out, going to look at that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids JWTs etc from the client info from being encoded into stream and consumer assignments proposals when they are not needed.
This will reduce the network bandwidth required to send such proposals in some deployments, as well as reducing the memory footprint of proposals queued in memory and the disk footprint required for the metalayer WAL.
Signed-off-by: Neil Twigg neil@nats.io