NRG: Don't mark current/healthy while paused with pending commits#6317
Merged
derekcollison merged 1 commit intomainfrom Jan 2, 2025
Merged
NRG: Don't mark current/healthy while paused with pending commits#6317derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There could be a call to
n.PauseApply(), for example during recovery if a max size is reached or when doing a stream catchup. This pauses the commits but was not reflected by the health check. Should only report current/healthy if we're paused but still up-to-date, with pending commits we should wait forn.ResumeApply()to be called and applies to be current.Signed-off-by: Maurice van Veen github@mauricevanveen.com