Optimise JetStream and Raft locking#6335
Merged
derekcollison merged 3 commits intomainfrom Jan 7, 2025
Merged
Conversation
None of these are ever mutated after the group is created, therefore we will create unnecessary lock contention on the group lock by trying to take it. Signed-off-by: Neil Twigg <neil@nats.io>
Otherwise consumer infos could hold the JS lock while waiting to take the Raft lock for a group. Signed-off-by: Neil Twigg <neil@nats.io>
…in create consumer Signed-off-by: Neil Twigg <neil@nats.io>
Member
Author
|
(Please regular merge rather than squash merge, I'd like these changes to stay in the commit log for individual blames.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimises some uses of the JetStream lock by reducing interactions between that and Raft group locks, which should mean that we don't end up in situations where we hold the JS lock while waiting to take a Raft lock etc.
Also updates a couple of the Raft group helper functions to not take the lock as they are returning values that are never mutated, creating unnecessary contention.
Signed-off-by: Neil Twigg neil@nats.io