Cherry-picks for 2.10.19-RC.3#5745
Merged
neilalexander merged 18 commits intorelease/v2.10.19from Aug 6, 2024
Merged
Conversation
neilalexander
force-pushed
the
neil/21019rc3
branch
from
cc3101d to
c01e342
Compare
Member
According to https://go.dev/issues/62278 a concrete go version has to include the patch number. The project declares the version as 1.21 which is invalid and will result in an error: GOTOOLCHAIN="go1.20+auto" go1.21.5 mod tidy go: downloading go1.21 (linux/amd64) go: download go1.21 for linux/amd64: toolchain not available Changed to 1.21.0 as this is the first actual release of go 1.21. Signed-off-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Using `net.JoinHostPort()` properly surrounds IPv6 literals with square brackets. Using `url.URL` ensures that hostnames will be properly encoded. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
…ed encryption keys Signed-off-by: Neil Twigg <neil@nats.io>
This is roughly 4x faster since there are no interface conversions and reduces allocations. Signed-off-by: Neil Twigg <neil@nats.io>
This reduces allocations and potentially speeds up some hot paths, such as in consumer waiting and gateway reply mapping. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
We'll still copy the string when asking the resolver, as we can't be sure whether a resolver will want to hold onto the string or not, but this should lead to improvements on the hot paths for routes and gateways when the cache doesn't contain the entries we want. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…to' which could lead to false positives.
However we need to pre-transform the 'from' token in case it contains transform direcrives, e.g. $1, {{}}.
Signed-off-by: Derek Collison <derek@nats.io>
When a slow consumer error is detected, the server will close the connection. In some race situations, it could be that the subscription interest is left intact, which would cause routed servers to continue routing messages although the interest should have been gone. The subscription could still be seen in the monitoring subscriptions list (when displaying with details), referencing a client connection that would be in the closed connection state. The monitoring route page of the other servers would still indicate that there is interest for this subject on the origin server. Resolves #5539 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
This avoids the alloc and copy and still allows the connection to be properly released. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
neilalexander
force-pushed
the
neil/21019rc3
branch
from
be9a0a9 to
1e3fc7e
Compare
This is a relaxed version of v2.11s change (https://github.com/nats-io/nats-server/pull/5676/files) which still allows cluster names with spaces in gateways and clusters. --------- Signed-off-by: Waldemar Quevedo <wally@nats.io>
This is a simpler PR than #5749 which just limits at the point of writing rather than at the point of buffering/framing. It allows us to set the deadline for each batch. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following:
ClientURL()properly formats IPv6 literal addresses #5725O_SYNCfor filestore meta files whenSyncAlwaysis enabled #5729Iterfaster by using generic sorting function #5734HasInterestin place ofMatchwhereSublistResultnot needed #5735profilez#5743getAccAndResultFromCacheby reducing allocations #5744The following were reverted before this PR:
Signed-off-by: Neil Twigg neil@nats.io