Reject leafnode cluster names with spaces#5732
Merged
neilalexander merged 2 commits intoneil/21019rc3from Aug 6, 2024
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
wallyqs
force-pushed
the
backport/v2.10.19
branch
from
800c7ab to
2248f4a
Compare
wallyqs
commented
Aug 1, 2024
wallyqs
force-pushed
the
backport/v2.10.19
branch
from
2248f4a to
8d86668
Compare
ripienaar
reviewed
Aug 1, 2024
wallyqs
force-pushed
the
backport/v2.10.19
branch
2 times, most recently
from
ec57f2d to
05a1131
Compare
wallyqs
force-pushed
the
backport/v2.10.19
branch
from
05a1131 to
66ebb63
Compare
mprimi
reviewed
Aug 1, 2024
wallyqs
force-pushed
the
backport/v2.10.19
branch
from
66ebb63 to
3833649
Compare
Member
kozlovic
requested changes
Aug 1, 2024
Member
kozlovic
left a comment
kozlovic
left a comment
There was a problem hiding this comment.
Should we do it also in processing the LEAF info or not?
wallyqs
force-pushed
the
backport/v2.10.19
branch
from
c841c00 to
3935fc6
Compare
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
backport/v2.10.19
branch
from
3935fc6 to
5177f3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relaxed version of v2.11s change (https://github.com/nats-io/nats-server/pull/5676/files) which still allows cluster names with spaces in gateways and clusters.