[FIXED] False positives on cyclic import maps with subject mappings.#5755
Merged
derekcollison merged 1 commit intomainfrom Aug 5, 2024
Merged
[FIXED] False positives on cyclic import maps with subject mappings.#5755derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
…to' which could lead to false positives.
However we need to pre-transform the 'from' token in case it contains transform direcrives, e.g. $1, {{}}.
Signed-off-by: Derek Collison <derek@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking for import cycles, only need to check 'from', not the 'to' which could lead to false positives.
However we need to pre-transform the 'from' token in case it contains transform directives, e.g. $1, {{}}.
Signed-off-by: Derek Collison derek@nats.io