Use O_SYNC for filestore meta files when SyncAlways is enabled#5729
Merged
derekcollison merged 2 commits intomainfrom Jul 31, 2024
Merged
Use O_SYNC for filestore meta files when SyncAlways is enabled#5729derekcollison merged 2 commits intomainfrom
O_SYNC for filestore meta files when SyncAlways is enabled#5729derekcollison merged 2 commits intomainfrom
Conversation
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/osync
branch
from
29c3b81 to
a35a7b8
Compare
neilalexander
changed the title
O_SYNC when writing some stream/consumer meta filesO_SYNC for filestore meta files when SyncAlways is enabled
…ed encryption keys Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will use
O_SYNCwhen writingmeta.inf,meta.sumandmeta.keyfiles for both streams and consumers when theSyncAlwaysfilestore option is enabled. It will also do the same when writing the consumer state file, or rewriting it if we are converting between ciphers.Signed-off-by: Neil Twigg neil@nats.io