Limit vector count in client outbound flushes#5749
Closed
neilalexander wants to merge 1 commit intomainfrom
Closed
Limit vector count in client outbound flushes#5749neilalexander wants to merge 1 commit intomainfrom
neilalexander wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/clientmaxiov
branch
from
323aaca to
df6c4f4
Compare
neilalexander
added a commit
that referenced
this pull request
Aug 5, 2024
This is a simpler PR than #5749 which just limits at the point of writing rather than at the point of buffering/framing. It allows us to set the deadline for each batch. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Aug 5, 2024
This is a simpler PR than #5749 which just limits at the point of writing rather than at the point of buffering/framing. It allows us to set the deadline for each batch. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Aug 6, 2024
This is a simpler PR than #5749 which just limits at the point of writing rather than at the point of buffering/framing. It allows us to set the deadline for each batch. Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
added a commit
that referenced
this pull request
Aug 6, 2024
This is a simpler PR than #5749 which just limits at the point of writing rather than at the point of buffering/framing. It allows us to set the deadline for each batch. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Aug 6, 2024
This is a simpler PR than #5749 which just limits at the point of writing rather than at the point of buffering/framing. It allows us to set the deadline for each batch. Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
net.Buffersimplementation in Go is a bit eager and tries to split across multiplewritevsyscalls if the input is greater thanIOV_MAX, which can mean that once a large amount of data gets buffered, the write deadline can become insufficient. This PR modifies the approach so that we don't send more than 1024 vectors intonet.Buffers.WriteTo()in one go.Signed-off-by: Neil Twigg neil@nats.io