Remove Go 1.20 from build, force building Go >= 1.21 in go.mod#5690
Merged
derekcollison merged 2 commits intomainfrom Jul 23, 2024
Merged
Remove Go 1.20 from build, force building Go >= 1.21 in go.mod#5690derekcollison merged 2 commits intomainfrom
derekcollison merged 2 commits intomainfrom
Conversation
According to https://go.dev/issues/62278 a concrete go version has to include the patch number. The project declares the version as 1.21 which is invalid and will result in an error: GOTOOLCHAIN="go1.20+auto" go1.21.5 mod tidy go: downloading go1.21 (linux/amd64) go: download go1.21 for linux/amd64: toolchain not available Changed to 1.21.0 as this is the first actual release of go 1.21. Signed-off-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
bruth
added a commit
that referenced
this pull request
Jul 30, 2024
Includes the following: * #5602 * #5672 * #5668 * #5607 * #5687 * #5695 * #5697 * #5704 * #5706 * #5709 * #5710 * #5713 * #5719 Some PRs specifically excluded: * #5707 — based on a 2.11 NRG PR * #5690 — continue to allow Go 1.20 for 2.10.x * Various other NRG PRs which are higher risk and destined for 2.11 instead
neilalexander
added a commit
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #5636