Fix WorkQueuePolicy retention issue#5697
Merged
derekcollison merged 2 commits intomainfrom Jul 25, 2024
Merged
Conversation
…tion` Signed-off-by: Neil Twigg <neil@nats.io>
…atch filters (#5699) Signed-off-by: Derek Collison <derek@nats.io> Signed-off-by: Derek Collison <derek@nats.io>
bruth
added a commit
that referenced
this pull request
Jul 30, 2024
Includes the following: * #5602 * #5672 * #5668 * #5607 * #5687 * #5695 * #5697 * #5704 * #5706 * #5709 * #5710 * #5713 * #5719 Some PRs specifically excluded: * #5707 — based on a 2.11 NRG PR * #5690 — continue to allow Go 1.20 for 2.10.x * Various other NRG PRs which are higher risk and destined for 2.11 instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isInterestRetentionfunction, which gates whether or not we runcheckInterestState, was matching for bothInterestPolicyandWorkQueuePolicy.This meant that a work queue stream could throw away messages for which there was no consumer interest as the consumer ack floors for other subjects moved up.
This PR changes
isInterestRetentionto match onlyInterestPolicywhich fixes the issue. Notably this doesn't change theackMsgbehaviour which will continue to remove messages once they have been acked.Signed-off-by: Neil Twigg neil@nats.io