Integration Candidate: 2020-04-22 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses CFE_ES_SysLogWrite_Unsync inside shared data lock
… for tables being 'cleaned up'
Fix #410, separate SYSLOG configurable defaults for power on and proc…
Fix #591, Avoid deadlock in CFE_ES_CreatObjects
Fix #503, better events for CFE_TBL_Load()
Fix #121, Add check for UsedFlag and sets APID to CFE_TBL_NOT_OWNED
Co-authored-by: Gerardo E. Cruz-Ortiz <[email protected]>
|
Note - PR #654 also needs to be added to this IC, after the hotfix gets another hotfix. |
jphickey
force-pushed
the
integration-candidate
branch
from
ec38f09
to
0818824
Compare
|
There was a breakdown in process for #606, TODO's that needed to be resolved got into the integration candidate. There's also something in this change that is breaking the usersguide document generation. @astrogeco @CDKnightNASA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #591, #121, #410, #503, #623
Testing performed
See PRs
Bundle CI - https://github.com/nasa/cFS/pull/74/checks?check_run_id=637311464
Expected behavior changes
PR #625 - Upon power on reset, default system log mode set to overwrite. Upon processor reset, default system log mode set to discard.
PR #619 - No longer locks while locked (no issue observed on linux/posix, but user reported issue on FreeRTOS 10)
PR #606 - Internal
CFE_TBL_LoadFromFile()API changed slightly to add AppName as a parameter. Return value fromLoadFromFile()no longer relevant for event generation.PR #622 - Updates
CFE_TBL_CleanUpAppsuch that it now checks the 'used flag' prior to callingCFE_TBL_RemoveAccessLinkfor a given TblHandle. Also sets the AppId toCFE_TBL_NOT_OWNEDafter removing the access descriptor link from linked list.PR #624 - Removed
OS_FS_SUCCESS, OS_FS_ERROR , OS_FS_ERR_INVALID_POINTER, OS_FS_ERR_NO_FREE_FDS , OS_FS_ERR_INVALID_FD, and OS_FS_UNIMPLEMENTEDfromosapi-os-filesys.hSystem(s) tested on
See PRs
Bundle CI - Ubuntu:Bionic
Additional context
nasa/cFS#74
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hafgeman, NASA-GSFC
Daniel Knutsen, NASA-GSFC
Christopher D. Knight NASA-ARC
Gerardo E. Cruz-Ortiz, NASA-GSFC