Fix #591, Avoid deadlock in CFE_ES_CreatObjects #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses CFE_ES_SysLogWrite_Unsync inside shared data lock
skliper
added
the
CCB:Ready
|
ping @thewonderidiot want to see if this works for you? |
|
Yep, this matches the changes I made locally to work around the problem. I've since gotten cFE 6.7.0 / OSAL 5.0.0 to fully boot on FreeRTOS, so these are the only instances of this issue that are encountered in the normal boot path, at least. Thanks! |
|
CCB 20200422 - Open an issue for an osal debug feature @jphickey. APPROVED |
|
Added nasa/osal#434 as an enhancement for OSAL to detect and warn about this. |
astrogeco
added
CCB - 20200422
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Now uses CFE_ES_SysLogWrite_Unsync inside shared data lock
Fixes #591
Testing performed
Expected behavior changes
No longer locks while locked (no issue observed on linux/posix, but user reported issue on FreeRTOS 10)
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC