Initialize system log mode implementation doesn't match requirement cES1522

[skliper]

Is your feature request related to a problem? Please describe.
Requirement cES1522 "Upon a Processor Reset, the cFE shall set the System Log Mode to discard."
Implementation:

cFE/fsw/cfe-core/src/es/cfe_es_task.c

Lines 236 to 239 in 5d7d766

	/*
	** Initialize systemlog to default mode
	*/
	CFE_ES_ResetDataPtr->SystemLogMode = CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE;

The build verification test just happens to pass because the sample configuration defaults the mode to discard.

Describe the solution you'd like
Update requirement or implementation.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[jphickey]

Recommend the requirement be reworded to say "Upon a Processor Reset, the cFE shall set the System Log Mode to the platform default"

[skliper]

I should have included the rational: "Want to preserve the System Events that may have captured the cause of the processor reset." So intent was to specifically override on a processor reset. Definitely open for discussion...

[jphickey]

And one can achieve (or fail to achieve) the goal stated in the rationale either way. It is just as easy to lose the syslog information with it set to discard, as the log may have been full already when the event occurred. At the end of the day this is just a system integration issue. Seems pretty cut and dry to me - cfe cannot "enforce" that deployments are correctly configured.

[skliper]

It's definitely one for the architects @acudmore @jwilmot. I'd think the vision in mind was for typical use default to overwrite for power on reset, force to discard on processor reset. User setting to discard at power on is certainly their choice to make, for which the discard on processor reset has no effect.

[skliper]

Path forward - separate configurable default for power on and processor reset. Default power on to overwrite and processor reset to discard. Requirements will be updated to match (will like req issue to this one). Users can modify however desired, but comes out of the box with the configuration that matches initial intent.

[skliper]

See cES1522 and cES1523 updates in #509