Fix #503, better events for CFE_TBL_Load()

[CDKnightNASA]

Describe the contribution
Addresses #503 but this is a draft, still need UT code updates. Simplified changes for CFE_TBL_Load() to make the code a bit easier to follow (hey, events generated when results are off-nominal, instead of at the end?)

Partially addresses #607

Testing performed
Initial build/run, UT not updated yet.

Expected behavior changes
Internal CFE_TBL_LoadFromFile() API changed slightly to add AppName as a parameter. Return value from LoadFromFile() no longer relevant for event generation.

System(s) tested on
Debian 9

Contributor Info - All information REQUIRED for consideration of pull request
[email protected]

[CDKnightNASA]

Updated the unit tests, removing "draft" status from pull request.

[skliper]

This routine mixes use of status and returns throughout that make's it hard to follow. Could it be refactored to clarify flow? Consider doing all the checks first to decide what work to do (or error to return), then do the work?

[CDKnightNASA]

There's quite a lot of conditional logic (whether loading the table from a file or memory block, whether the load is partial, etc) so can't do a lot "up-front". I've refactored to do fail=>event+return to reduce deeply-nested if struct of original code. Unsure if it could be further refactored without changing/removing behavior.

[astrogeco]

CCB 20200422 - Approve and open a new ticket to refactor and reduce complexity. There's lots of return statements and we probably don't want to add more.

[skliper]

#600 is the table load refactor, I'll hijack and include the complexity reduction effort

[jphickey]

This is breaking the integration-candidate build for me, it is using "ThisAppId" variable uninitialized:

/home/joe/code/cfecfs/github/cfe/fsw/cfe-core/src/tbl/cfe_tbl_api.c: In function ‘CFE_TBL_Load’:
/home/joe/code/cfecfs/github/cfe/fsw/cfe-core/src/tbl/cfe_tbl_api.c:687:5: error: ‘ThisAppId’ is used uninitialized in this function [-Werror=uninitialized]
  687 |     CFE_ES_GetAppName(AppName, ThisAppId, OS_MAX_API_NAME);

[astrogeco]

@CDKnightNASA