CFE_ES_CreateObjects calls CFE_ES_WriteToSysLog while holding shared data lock

[thewonderidiot]

Describe the bug
During core service task create, CFE_ES_CreateObjects() calls CFE_ES_WriteToSysLog() while already holding the shared data lock in two places, resulting in a recursive lock / deadlock.

• Location 1
• Location 2

Expected behavior
It appears it should be calling CFE_ES_SysLogWrite_Unsync() instead.

Code snips
The second location makes the issue pretty clear:

                  CFE_ES_WriteToSysLog("ES Startup: Core App: %s created. App ID: %d\n",
                                       CFE_ES_ObjectTable[i].ObjectName,j);
                                       
                  /*
                  ** Increment the registered App and Registered External Task variables.
                  */
                  CFE_ES_Global.RegisteredTasks++;
                  CFE_ES_Global.RegisteredCoreApps++;
                  
                  CFE_ES_UnlockSharedData(__func__,__LINE__);

System observed on:

• OS: FreeRTOS 10
• Versions: cFE 6.7.0, OSAL 5.0.0

Reporter Info
Mike Stewart, Capella Space Corporation