-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent recursive panics from happening #50
Conversation
Previously if a panic occured while processing a panic the logic would get stuck in a loop trying to handle the panic. Now if a panic happens while processing a panic, a hard abort is immediately executed.
43e1c70
to
d97b920
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## nick/panic-log-aborts #50 +/- ##
======================================================
Coverage 92.87% 92.87%
======================================================
Files 9 9
Lines 323 323
======================================================
Hits 300 300
Misses 23 23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but I think we're probably going to need GLOBAL_PANIC_COUNT: AtomicUsize
in order to properly handle mutex poisoning.
Captured this in #53 |
Previously if a panic occured while processing a panic the logic would
get stuck in a loop trying to handle the panic.
Now if a panic happens while processing a panic, a hard abort is
immediately executed.