Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent recursive panics from happening #50

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

Previously if a panic occured while processing a panic the logic would
get stuck in a loop trying to handle the panic.
Now if a panic happens while processing a panic, a hard abort is
immediately executed.

@nick-mobilecoin nick-mobilecoin mentioned this pull request Jan 30, 2023
12 tasks
Previously if a panic occured while processing a panic the logic would
get stuck in a loop trying to handle the panic.
Now if a panic happens while processing a panic, a hard abort is
immediately executed.
@codecov-commenter
Copy link

Codecov Report

Merging #50 (d97b920) into nick/panic-log-aborts (cdc44ad) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                  Coverage Diff                   @@
##           nick/panic-log-aborts      #50   +/-   ##
======================================================
  Coverage                  92.87%   92.87%           
======================================================
  Files                          9        9           
  Lines                        323      323           
======================================================
  Hits                         300      300           
  Misses                        23       23           
Impacted Files Coverage Δ
panic/src/lib.rs 100.00% <ø> (ø)
panic/sys/src/lib.rs 100.00% <ø> (ø)
panic/sys/src/panicking.rs 97.56% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I think we're probably going to need GLOBAL_PANIC_COUNT: AtomicUsize in order to properly handle mutex poisoning.

Base automatically changed from nick/panic-log-aborts to main February 1, 2023 21:55
@nick-mobilecoin
Copy link
Collaborator Author

This is good, but I think we're probably going to need GLOBAL_PANIC_COUNT: AtomicUsize in order to properly handle mutex poisoning.

Captured this in #53

@nick-mobilecoin nick-mobilecoin merged commit 5652805 into main Feb 1, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/prevent-recursive-panic branch February 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update rust code size/S Small PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants