-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public function thread::panicking()
#34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2023
Merged
Merged
Merged
nick-mobilecoin
commented
Jan 11, 2023
This was referenced Jan 11, 2023
Merged
nick-mobilecoin
force-pushed
the
nick/panicking
branch
from
January 13, 2023 21:51
7e78c2f
to
33adb4d
Compare
nick-mobilecoin
force-pushed
the
nick/thread-panicking
branch
from
January 13, 2023 21:51
6204553
to
a909cb7
Compare
nick-mobilecoin
force-pushed
the
nick/panicking
branch
from
January 13, 2023 22:02
33adb4d
to
993ae4d
Compare
nick-mobilecoin
force-pushed
the
nick/thread-panicking
branch
from
January 13, 2023 22:02
a909cb7
to
240ef50
Compare
nick-mobilecoin
force-pushed
the
nick/panicking
branch
from
January 13, 2023 22:26
993ae4d
to
35a0431
Compare
nick-mobilecoin
force-pushed
the
nick/thread-panicking
branch
from
January 13, 2023 22:26
240ef50
to
3a4a4cc
Compare
This was referenced Jan 17, 2023
`thread::panicking()` returns if the current thread is panicking
nick-mobilecoin
force-pushed
the
nick/panicking
branch
from
January 24, 2023 16:03
35a0431
to
f941f1c
Compare
nick-mobilecoin
force-pushed
the
nick/thread-panicking
branch
from
January 24, 2023 16:03
3a4a4cc
to
edffc1d
Compare
varsha888
reviewed
Jan 24, 2023
varsha888
approved these changes
Jan 24, 2023
This was referenced Jan 24, 2023
jcape
reviewed
Jan 25, 2023
jcape
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I suspect tests may end up being flaky if they aren't run serially...
✅ This pull request merged successfully as part of a Graphite job |
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread::panicking()
returns if the current thread is panicking