Add untrusted side of stderr from enclave

[nick-mobilecoin]

Add an ocall implementation ocall_stderr() which is where stderr from an enclave will be directed to. By default any content passed to the ocall_stderr() will be directed to the untrusted (host) stderr. Consumers of the crate can direct this output by providing a WriteAll implementation to stderr_write_all().

[nick-mobilecoin]

@jcape When/if you get a chance might do a quick look over and see if this is "a piece" you were thinking for providing the panic with stack traces out of the enclave

[nick-mobilecoin]

Current dependencies on/for this PR:

• main
  • PR Update CI for SGX SDK action update #14
    • PR Move panic to panic/abort #13
      • PR Add untrusted side of stderr from enclave #15 👈
        • PR Add mc-sgx-io #22
          • PR Add mc-sgx-panic-log #24
            • PR Add mc-sgx-panic crate for common panic handling #30
              • PR Add panicking::panic_count to mc-sgx-panic #31
                • PR Update CODEOWNERS file #32
                  • PR Add panicking::panicking() function #33
                  • PR Add public function thread::panicking() #34
                  • PR Add mc-sgx-sync crate #35
                  • PR Add poison.rs to mc-sgx-sync crate #36
                  • PR Add sys module to mc-sgx-sync #39
                  • PR Add mutex.rs to mc-sgx-sync crate #40
                  • PR Use a static buffer for panic messages #41
                  • PR Add mc-sgx-sync::sys::locks::Condvar #42
                  • PR Add Condvar to mc-sgx-sync crate #43
                  • PR Add mc-sgx-sync::sys::locks::RwLock #44
                  • PR Add RwLock to mc-sgx-sync #45
                  • PR Add example usage for mc-sgx-sync and std::sync #46
                  • PR Merge panic-abort and panic-log crates into mc-sgx-panic #48
                  • PR Prevent recursive panics from happening #50
                  • PR Remove unneeded traits on sys types #51
        • PR Rename mc-sgx-io to mc-sgx-io-untrusted #21

This comment was auto-generated by Graphite.

[awygle]

This looks good to me. I agree with the comment about prioritizing the enclave build tools at this time, this looks like a lot of copy-paste.

[NotGyro]

This looks good to me.

[jcape]

I think you'll probably need to change pcl_key.bin's attributes directly as well, unfortunately

[nick-mobilecoin]

I think you'll probably need to change pcl_key.bin's attributes directly as well, unfortunately

Still looking, but my hunch is github is caching the previous "no-binary" version

➜  sgx-std git:(nick/stderr) git check-attr -a test_enclave/src/pcl_key.bin
test_enclave/src/pcl_key.bin: binary: set
test_enclave/src/pcl_key.bin: diff: unset
test_enclave/src/pcl_key.bin: merge: unset
test_enclave/src/pcl_key.bin: text: unset

[jcape]

Maybe needs a push?

[nick-mobilecoin]

Tried doing the leap frog but it still fails, most things I run across say that github is using git's internal mechanism which gives me

➜  sgx-std git:(nick/stderr) ✗ git diff origin/main
...
diff --git a/test_enclave/src/pcl_key.bin b/test_enclave/src/pcl_key.bin
new file mode 100644
index 0000000..508ec12
Binary files /dev/null and b/test_enclave/src/pcl_key.bin differ

So git doesn't seem to care that the attributes file was added after in the same set of commits

[jcape]

Yeah, OK, I guess we'll see if it works when we diff it later.