Add poison.rs to `mc-sgx-sync` crate #36

nick-mobilecoin · 2023-01-12T15:57:04Z

Add poison.rs implementation which more or less copies from
rust source at
606c3907

nick-mobilecoin · 2023-01-12T15:57:33Z

Current dependencies on/for this PR:

main
- PR Update CI for SGX SDK action update #14
  - PR Move panic to panic/abort #13
    - PR Add untrusted side of stderr from enclave #15
      - PR Add mc-sgx-io #22
        
        PR Add mc-sgx-panic-log #24
        
        PR Add mc-sgx-panic crate for common panic handling #30
        
        PR Add panicking::panic_count to mc-sgx-panic #31
        
        PR Update CODEOWNERS file #32
        
        PR Add panicking::panicking() function #33
        PR Add public function thread::panicking() #34
        PR Add mc-sgx-sync crate #35
        PR Add poison.rs to mc-sgx-sync crate #36 👈
        PR Add sys module to mc-sgx-sync #39
        PR Add mutex.rs to mc-sgx-sync crate #40
        PR Use a static buffer for panic messages #41
        PR Add mc-sgx-sync::sys::locks::Condvar #42
        PR Add Condvar to mc-sgx-sync crate #43
        PR Add mc-sgx-sync::sys::locks::RwLock #44
        PR Add RwLock to mc-sgx-sync #45
        PR Add example usage for mc-sgx-sync and std::sync #46
        PR Merge panic-abort and panic-log crates into mc-sgx-panic #48
        PR Prevent recursive panics from happening #50
        PR Remove unneeded traits on sys types #51
      - PR Rename mc-sgx-io to mc-sgx-io-untrusted #21

This comment was auto-generated by Graphite.

sync/src/poison.rs

rust-toolchain.toml

sync/src/poison.rs

codecov-commenter · 2023-01-13T21:59:45Z

Codecov Report

Merging #36 (541d217) into nick/sync-crate (2b1518c) will decrease coverage by 23.71%.
The diff coverage is 0.00%.

@@                 Coverage Diff                  @@
##           nick/sync-crate      #36       +/-   ##
====================================================
- Coverage            91.94%   68.23%   -23.72%     
====================================================
  Files                    8        9        +1     
  Lines                  236      318       +82     
====================================================
  Hits                   217      217               
- Misses                  19      101       +82

Impacted Files	Coverage Δ
sync/src/lib.rs	`100.00% <ø> (ø)`
sync/src/poison.rs	`0.00% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Add poison.rs implementation which more or less copies from [rust source](https://github.com/rust-lang/rust.git) at [606c3907](rust-lang/rust@606c390)

nick-mobilecoin · 2023-01-26T15:11:38Z

✅ This pull request merged successfully as part of a Graphite job
Stack job ID: HgREqLwB7JxPkCuBxNeY.
See details on graphite.dev

nick-mobilecoin · 2023-01-26T15:18:49Z

@varsha888 bumping you for review since I needed to restack after your review

nick-mobilecoin requested a review from jcape as a code owner January 12, 2023 15:57

This was referenced Jan 12, 2023

Update CI for SGX SDK action update #14

Merged

Move panic to panic/abort #13

Merged

Add untrusted side of stderr from enclave #15

Merged

github-actions bot requested review from awygle and varsha888 January 12, 2023 15:57

nick-mobilecoin mentioned this pull request Jan 12, 2023

Rename mc-sgx-io to mc-sgx-io-untrusted #21

Closed

github-actions bot assigned nick-mobilecoin Jan 12, 2023

This was referenced Jan 12, 2023

Add mc-sgx-panic-log #24

Merged

Add mc-sgx-io #22

Merged

github-actions bot added size/L Large PRs rust Pull requests that update rust code labels Jan 12, 2023

nick-mobilecoin commented Jan 12, 2023

View reviewed changes

sync/src/poison.rs Show resolved Hide resolved

nick-mobilecoin commented Jan 12, 2023

View reviewed changes

rust-toolchain.toml Outdated Show resolved Hide resolved

nick-mobilecoin commented Jan 12, 2023

View reviewed changes

sync/src/poison.rs Show resolved Hide resolved

nick-mobilecoin commented Jan 12, 2023

View reviewed changes

sync/src/poison.rs Show resolved Hide resolved

nick-mobilecoin force-pushed the nick/poison branch from 88c8c5c to efb5c66 Compare January 12, 2023 16:03

github-actions bot added the github_actions Pull requests that update github actions label Jan 12, 2023

awygle approved these changes Jan 13, 2023

View reviewed changes

jcape approved these changes Jan 13, 2023

View reviewed changes

nick-mobilecoin force-pushed the nick/sync-crate branch from 7c3ce9a to 9661290 Compare January 13, 2023 21:51

nick-mobilecoin force-pushed the nick/poison branch from efb5c66 to 058fb8c Compare January 13, 2023 21:51

github-actions bot removed the github_actions Pull requests that update github actions label Jan 13, 2023

nick-mobilecoin force-pushed the nick/sync-crate branch from 9661290 to 2b1518c Compare January 13, 2023 22:02

nick-mobilecoin force-pushed the nick/poison branch from 058fb8c to 541d217 Compare January 13, 2023 22:02

nick-mobilecoin force-pushed the nick/sync-crate branch from 2b1518c to a18f36f Compare January 13, 2023 22:26

nick-mobilecoin force-pushed the nick/poison branch from 541d217 to 5383581 Compare January 13, 2023 22:26

This was referenced Jan 17, 2023

Add sys module to mc-sgx-sync #39

Merged

Add mutex.rs to mc-sgx-sync crate #40

Merged

varsha888 approved these changes Jan 23, 2023

View reviewed changes

This was referenced Jan 23, 2023

Use a static buffer for panic messages #41

Merged

Thread (mc-sgx-sync) #29

Closed

nick-mobilecoin added 2 commits January 24, 2023 08:02

Add poison.rs to mc-sgx-sync crate

0715e66

Add poison.rs implementation which more or less copies from [rust source](https://github.com/rust-lang/rust.git) at [606c3907](rust-lang/rust@606c390)

Add rust project copyright for poison.rs

90d36b4

nick-mobilecoin force-pushed the nick/sync-crate branch from a18f36f to c5efed0 Compare January 24, 2023 16:03

nick-mobilecoin force-pushed the nick/poison branch from 193148c to 90d36b4 Compare January 24, 2023 16:03

This was referenced Jan 24, 2023

Add mc-sgx-sync::sys::locks::Condvar #42

Merged

Add Condvar to mc-sgx-sync crate #43

Merged

Add mc-sgx-sync::sys::locks::RwLock #44

Merged

Add RwLock to mc-sgx-sync #45

Merged

nick-mobilecoin requested a review from varsha888 January 26, 2023 15:18

varsha888 approved these changes Jan 26, 2023

View reviewed changes

Base automatically changed from nick/sync-crate to main January 26, 2023 17:37

nick-mobilecoin merged commit 563bdf3 into main Jan 26, 2023

nick-mobilecoin deleted the nick/poison branch January 26, 2023 17:37

This was referenced Jan 27, 2023

Add example usage for mc-sgx-sync and std::sync #46

Merged

Merge panic-abort and panic-log crates into mc-sgx-panic #48

Merged

Prevent recursive panics from happening #50

Merged

Remove unneeded traits on sys types #51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add poison.rs to `mc-sgx-sync` crate #36

Add poison.rs to `mc-sgx-sync` crate #36

nick-mobilecoin commented Jan 12, 2023

nick-mobilecoin commented Jan 12, 2023 •

edited

Loading

codecov-commenter commented Jan 13, 2023 •

edited

Loading

nick-mobilecoin commented Jan 26, 2023 •

edited

Loading

nick-mobilecoin commented Jan 26, 2023

Add poison.rs to mc-sgx-sync crate #36

Add poison.rs to mc-sgx-sync crate #36

Conversation

nick-mobilecoin commented Jan 12, 2023

nick-mobilecoin commented Jan 12, 2023 • edited Loading

codecov-commenter commented Jan 13, 2023 • edited Loading

Codecov Report

nick-mobilecoin commented Jan 26, 2023 • edited Loading

nick-mobilecoin commented Jan 26, 2023

Add poison.rs to `mc-sgx-sync` crate #36

Add poison.rs to `mc-sgx-sync` crate #36

nick-mobilecoin commented Jan 12, 2023 •

edited

Loading

codecov-commenter commented Jan 13, 2023 •

edited

Loading

nick-mobilecoin commented Jan 26, 2023 •

edited

Loading