-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mc-sgx-panic
crate for common panic handling
#30
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
cf501b9
to
b4249a1
Compare
Codecov Report
@@ Coverage Diff @@
## panic-log #30 +/- ##
=============================================
+ Coverage 87.80% 87.90% +0.09%
=============================================
Files 4 5 +1
Lines 123 124 +1
=============================================
+ Hits 108 109 +1
Misses 15 15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, simple introduction of a new crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dfb54d8
to
8c1f25f
Compare
b4249a1
to
ad10063
Compare
This change is in preparation of the
mc-sgx-sync
crate, #29In order to support Mutex poisoning there needs to be an implementation of
panicking()
, https://doc.rust-lang.org/src/std/sync/poison.rs.html#33This panicking logic should probably be common such that it's not re-implemented for
mc-sgx-panic-abort
andmc-sgx-panic-log
It may be appropriate to only have
mc-sgx-panic
and then use featuresabort
andlog
to specify the implementation to use. While features are inherently additive in Cargo it's not unheard of to use mutually exclusive features, https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features