-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a static buffer for panic messages #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2023
Merged
Merged
This was referenced Jan 23, 2023
Merged
Merged
Closed
nick-mobilecoin
commented
Jan 23, 2023
nick-mobilecoin
force-pushed
the
nick/mutex
branch
from
January 24, 2023 16:03
68452c6
to
52f6ca9
Compare
nick-mobilecoin
force-pushed
the
panic-buffer
branch
from
January 24, 2023 16:03
3444cd5
to
0c25d09
Compare
awygle
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
varsha888
approved these changes
Jan 25, 2023
This was referenced Jan 25, 2023
nick-mobilecoin
force-pushed
the
nick/mutex
branch
from
January 25, 2023 22:05
52f6ca9
to
f230937
Compare
nick-mobilecoin
force-pushed
the
panic-buffer
branch
from
January 25, 2023 22:05
0c25d09
to
1d96ceb
Compare
nick-mobilecoin
force-pushed
the
nick/mutex
branch
from
January 26, 2023 15:32
f230937
to
38f18fa
Compare
nick-mobilecoin
force-pushed
the
panic-buffer
branch
from
January 26, 2023 15:33
1d96ceb
to
fa6317c
Compare
jcape
reviewed
Jan 27, 2023
nick-mobilecoin
force-pushed
the
nick/mutex
branch
from
January 30, 2023 22:53
38f18fa
to
edfdcb1
Compare
nick-mobilecoin
force-pushed
the
panic-buffer
branch
from
January 30, 2023 22:53
fa6317c
to
ee48383
Compare
Previously panic messages were using `to_string()` which required allocating a string. Now a static buffer is used for building up the panic message to prevent possibly panicking allocating the message `String`.
nick-mobilecoin
force-pushed
the
nick/mutex
branch
from
January 30, 2023 22:56
edfdcb1
to
dc33a43
Compare
nick-mobilecoin
force-pushed
the
panic-buffer
branch
from
January 30, 2023 22:56
ee48383
to
cadfb66
Compare
@varsha888 bump for re-review due to restack |
varsha888
approved these changes
Jan 30, 2023
✅ This pull request merged successfully as part of a Graphite job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously panic messages were using
to_string()
which requiredallocating a string. Now a static buffer is used for building up the
panic message to prevent possibly panicking allocating the message
String
.