Skip to content

[vcpkg] Fix Windows pipeline's outdated Ninja reference#13722

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
ras0219-msft:dev/roschuma/ninja1-10-1
Sep 25, 2020
Merged

[vcpkg] Fix Windows pipeline's outdated Ninja reference#13722
BillyONeal merged 1 commit intomicrosoft:masterfrom
ras0219-msft:dev/roschuma/ninja1-10-1

Conversation

@ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Sep 24, 2020

@cenit
Copy link
Contributor

cenit commented Sep 24, 2020

@JackBoosY we need to do a similar fix in #12612

@PhoebeHui PhoebeHui added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Sep 25, 2020
@JackBoosY
Copy link
Contributor

@cenit The best way is wait for this PR merge.

@PhoebeHui PhoebeHui added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Sep 25, 2020
@cenit
Copy link
Contributor

cenit commented Sep 25, 2020

@cenit The best way is wait for this PR merge.

No i mean we will have to change references to CMake there, in the same line @ras0219 changed references to ninja here

@BillyONeal BillyONeal merged commit 57b3738 into microsoft:master Sep 25, 2020
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 26, 2020
[vcpkg] Fix Windows pipeline's outdated Ninja reference (microsoft#13722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants