Skip to content

[usd] fix dll path and update to 20.08#13687

Merged
strega-nil merged 12 commits intomicrosoft:masterfrom
ousttrue:fix_usd_install
Nov 12, 2020
Merged

[usd] fix dll path and update to 20.08#13687
strega-nil merged 12 commits intomicrosoft:masterfrom
ousttrue:fix_usd_install

Conversation

@ousttrue
Copy link
Contributor

Describe the pull request

The following Debug and Release work fine.

#define NOMINMAX
#include <pxr/usd/usd/stage.h>
#include <pxr/usd/sdf/path.h>
#include <pxr/usd/usdGeom/sphere.h>

int main()
{
    auto stage = pxr::UsdStage::CreateInMemory();
    auto sphere = pxr::UsdGeomSphere::Define(stage, pxr::SdfPath("/TestSphere"));
    auto root = stage->GetRootLayer();
    root->Export("test_sphere.usda");
    return 0;
}

@ousttrue ousttrue changed the title [pixar usd] fix cmake runtime path and update to 20.08 [pixar usd] fix dll path and update to 20.08 Sep 23, 2020
@LilyWangL LilyWangL changed the title [pixar usd] fix dll path and update to 20.08 [usd] fix dll path and update to 20.08 Sep 24, 2020
@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision labels Sep 24, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR. Now usd build failed on Linux and MACOS with the following error:

CMake Error at /mnt/vcpkg-ci/downloads/tools/cmake-3.17.2-linux/cmake-3.17.2-Linux-x86_64/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find TBB (missing: tbb) (found version "2020.1")
Call Stack (most recent call first):
  /mnt/vcpkg-ci/downloads/tools/cmake-3.17.2-linux/cmake-3.17.2-Linux-x86_64/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindTBB.cmake:277 (find_package_handle_standard_args)
  /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:493 (_find_package)
  cmake/defaults/Packages.cmake:112 (find_package)
  CMakeLists.txt:23 (include)

@ousttrue
Copy link
Contributor Author

All green 👍
TBB handling is difficult.

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ousttrue
Copy link
Contributor Author

cmake TARGET_PATH fixed.
CI x86_windows #13722

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ousttrue
Copy link
Contributor Author

ousttrue commented Oct 9, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 13687 in repo microsoft/vcpkg

@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 10, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Oct 14, 2020
@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Nov 11, 2020
@strega-nil
Copy link
Contributor

Gonna let this run through CI after merging with master, then merge :)

@strega-nil strega-nil merged commit 4733e26 into microsoft:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants