[lerc] Export Package#13724
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Oct 9, 2020
n4z4m3:lerc_create_package
Merged
[lerc] Export Package#13724BillyONeal merged 4 commits intomicrosoft:masterfrom n4z4m3:lerc_create_package
BillyONeal merged 4 commits intomicrosoft:masterfrom
n4z4m3:lerc_create_package
Conversation
LilyWangL
added
the
category:port-feature
LilyWangL
approved these changes
Sep 25, 2020
Contributor
|
Blocked by #13722. |
n4z4m3
commented
Sep 25, 2020
Contributor
Author
n4z4m3
left a comment
n4z4m3
left a comment
There was a problem hiding this comment.
Agree with these changes
ras0219
approved these changes
Sep 25, 2020
Contributor
Author
|
I am seeing that the CI x86_windows is failing, however, when I run it locally, it works fine. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LilyWangL
added
the
info:needs-maintainer-attention
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
Any ideas why the checks are not getting through? |
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13723
The lerc library does not export a package which makes it difficult to use in other CMake projects.
This PR creates a patch to the CMakeLists.txt file to export a package.