Skip to content

[x264] Fix *inx dynamic build#13684

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/13683
Sep 28, 2020
Merged

[x264] Fix *inx dynamic build#13684
ras0219-msft merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/13683

Conversation

@JackBoosY
Copy link
Contributor

if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")

Since x264 support linux, this condition is incorrect.

Fixes #13683.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Sep 23, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 24, 2020
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once merged with master

@JackBoosY
Copy link
Contributor Author

Blocked by #13722.

@JackBoosY
Copy link
Contributor Author

blocked by #13765.

@ras0219-msft ras0219-msft merged commit a8c046b into microsoft:master Sep 28, 2020
@JackBoosY JackBoosY deleted the dev/jack/13683 branch September 28, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[x264] x64-linux-dynamic install failure

3 participants